clean up of wikkawiki

[nerdling (Jeremy Lavergne)]

There are some things that need updated in wikkawiki.

1. The php5 and mysql5 dependencies need rewritten to check for binaries (there exists more than one package that produces a working php5/mysql5.
2. Does wikkawiki really require a MySQL server to be present on the same computer? Is it not sufficient to access a MySQL server on another computer? If so, no dependency on a MySQL port should be stated.
3. The destroot phase should be reworked so that the symlink in the osxdocpath is created inside the destroot.
4. if [variant] content should just be put into the variants

Do you approve of the attached patch? Are there other changes you would like made?

[nerdling (Jeremy Lavergne)]

further changes (whitespace, post-activate, lone {)

[ryandesign (Ryan Carsten Schmidt)]

Looks good, except "xinstall -m 0666 {$wikkapath}/wikka.config.php" won't work; xinstall copies a file from one place to another, but if you only want to change its mode, then "file attributes" is the way to go. Also you may want to change the wikkapath variable so it does not begin with the destroot (instead prepend the destroot variable to the wikkapath variable when you want to use it) so that you can use the wikkapath variable in the use_osx_docroot post-destroot phase too.

[nerdling (Jeremy Lavergne)]

xinstall => file attributes, modified ${wikkapath}

[nerdling (Jeremy Lavergne)]

Replying to ryandesign@…:

…you can use the wikkapath variable in the use_osx_docroot post-destroot phase too.

Does the OS X apache allow following symlinks? If not, then the use_osx_docroot won't work.

[nerdling (Jeremy Lavergne)]

moved ui_msg back into post-activate. seemingly cannot override per variant.

[brian@…]

Correct target dir in post-destroot symlink creation

[brian@…]

Suggested changes have been tested and look fine to me.

Does wikkawiki really require a MySQL server to be present on the same computer? Is it not sufficient to access a MySQL server on another computer? If so, no dependency on a MySQL port should be stated.

We've never really tested the app against a remote MySQL instance. In our experience, the vast majority of our users would probably expect MySQL to be installed locally.

[nerdling (Jeremy Lavergne)]

Committed as r46832.

[(none)]

Milestone Port Bugs deleted