Webkit-gtk 1.1.15.4 fails to build on Snow Leopard

[daniel@…]

I'm trying to install Midori and webkit-gtk 1.1.15.4 fails to build.

I was doing universal builds due to wine-devel and I thought that might be the problem, so I completely uninstalled all of Macports and rm -rf /opt/local and then reinstalled everything again without wine-devel (no longer forcing universal on any ports)

The port is from the Australian mirror on a Macbook Unibody - Mac OS X 10.6.3

Here's the error output with the -d flag. I can't decipher it:

In file included from /usr/include/xlocale.h:77,
                 from /opt/local/include/libintl.h:24,
                 from /opt/local/include/glib-2.0/glib/gi18n-lib.h:25,
                 from WebKit/gtk/WebCoreSupport/ContextMenuClientGtk.cpp:29:
/usr/include/xlocale/_ctype.h: In function 'int __istype_l(__darwin_ct_rune_t, long unsigned int, _xlocale*)':
/usr/include/xlocale/_ctype.h:47: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope
/usr/include/xlocale/_ctype.h: In function '__darwin_ct_rune_t __toupper_l(__darwin_ct_rune_t, _xlocale*)':
/usr/include/xlocale/_ctype.h:54: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope
/usr/include/xlocale/_ctype.h: In function '__darwin_ct_rune_t __tolower_l(__darwin_ct_rune_t, _xlocale*)':
/usr/include/xlocale/_ctype.h:61: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope
In file included from /usr/include/xlocale.h:77,
                 from /opt/local/include/libintl.h:24,
                 from /opt/local/include/glib-2.0/glib/gi18n-lib.h:25,
                 from WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:46:
/usr/include/xlocale/_ctype.h: In function 'int __istype_l(__darwin_ct_rune_t, long unsigned int, _xlocale*)':
/usr/include/xlocale/_ctype.h:47: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope
/usr/include/xlocale/_ctype.h: In function '__darwin_ct_rune_t __toupper_l(__darwin_ct_rune_t, _xlocale*)':
/usr/include/xlocale/_ctype.h:54: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope
/usr/include/xlocale/_ctype.h: In function '__darwin_ct_rune_t __tolower_l(__darwin_ct_rune_t, _xlocale*)':
/usr/include/xlocale/_ctype.h:61: error: 'isascii_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h' was not declared in this scope
make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ContextMenuClientGtk.lo] Error 1
make: *** [all] Error 2
Error: Target org.macports.build returned: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/work/webkit-1.1.15.4" && /usr/bin/make -j2 all " returned error 2
DEBUG: Backtrace: shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/work/webkit-1.1.15.4" && /usr/bin/make -j2 all " returned error 2
    while executing
"command_exec build"
    (procedure "portbuild::build_main" line 9)
    invoked from within
"$procedure $targetname"
Warning: the following items did not execute (for webkit-gtk): org.macports.activate org.macports.build org.macports.destroot org.macports.install
Error: Status 1 encountered during processing.
To report a bug, see <http://guide.macports.org/#project.tickets>

[jmroot (Joshua Root)]

Please remember to cc the maintainers.

[daniel@…]

I just tried a fresh install of MacPorts on a PowerBook G4 running Mac OS X Server 10.5.8 and attempted to install Midori in the same manner. Webkit-gtk failed to build at:

make[1]: *** [WebKit/gtk/WebCoreSupport/libwebkit_1_0_la-ChromeClientGtk.lo] Error 1

is anyone having success building the current webkit-gtk?

[zheaton@…]

I'm seeing the same error logs (line-for-line identical) as Daniel. I'm running 10.6.3 on Unibody Macbook Pro i7.

[zheaton@…]

Cc Me!

[elelay (Eric Le Lay)]

please see #24622 by applying the last patch : patch-WebCore-config-h.diff, you should be able to build it...

[elelay (Eric Le Lay)]

Cc Me!

[daniel@…]

Thanks elelay, the patch worked!

Being new to this, I followed some of the advice in the ​Macports Guide on patching and figured it out from there.

Just for anyone looking for a step by step solution, here's what I did:

sudo port clean --all webkit-gtk

sudo port selfupdate

sudo port install webkit-gtk

(These steps were not necessary, but safe to do)

The build failed at this point and then I applied the ​patch-WebCore-config-h.diff patch which I downloaded into ~/Downloads;

cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/work/webkit-1.1.15.4

patch -p0 < ~/Downloads/patch-WebCore-config-h.diff

And finally:

sudo port install webkit-gtk

sudo port install midori

Midori is working again! Thanks everybody.

[ryandesign (Ryan Carsten Schmidt)]

webkit-gtk has been updated to 1.2.1. Is this still a problem?

[daniel@…]

webkit-gtk @1.2.1_0 built without any problems. Good work!

[elelay (Eric Le Lay)]

so I'm closing the ticket. Thanks for reporting and taking the time to explain how to apply the patch !

[tbanchuin@…]

Cc Me!