digikam: updated portfile to 1.6.0

[jgosmann (Jan Gosmann)]

Finally I was able to update the outdated digikam port. I will attach a patch for the portfile.

[jgosmann (Jan Gosmann)]

See also the related tickets #27348 and #27349.

[ryandesign (Ryan Carsten Schmidt)]

Your patch hardcodes /opt/local, but shouldn't.

You also added a dependency on mysql5-server. Does digikam really require a MySQL server running on the same computer, or would a MySQL server on another computer be sufficient? If so, then the dependency should be on mysql5, not on mysql5-server, and should also be written so that mysql5-devel could satisfy it (see any existing port that depends on mysql5 for an example of how this is done).

[jgosmann (Jan Gosmann)]

I fixed the hardcoded /opt/local path and removed the mysql5-server dependency. Nevertheless, digikam depends on kdegraphics4 which depends on other ports depending on mysql5-server.

[julien@…]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

You removed the mysql5-server dependency, but did not replace it with a mysql5 dependency? Does this software use the MySQL libraries?

The only port in MacPorts today that depends on mysql5-server is akonadi, and this is an error. I already brought this up in #25547 but it was not addressed. I have re-filed this request as #27404.

[jgosmann (Jan Gosmann)]

Patch to apply to the portfile

[jgosmann (Jan Gosmann)]

Digikam 1.6.0 has just been released today. I've attached an updated portfile.

About the mysql dependeny I am a bit unsure. I added it for the 1.5.0 version, because for some reason these configure options concerning MySQL were needed. With 1.6.0 this is not any longer the case and MySQL is not listed as dependency in the Readme file.

I suppose that MySQL is not really a dependency of Digikam and did not include it again in the new Portfile. But I contacted the main developer and depending on his answer I will add that dependency.

[julien@…]

I think mysql is an optional dependency as digikam can be used with sqlite as well.

Julien

[jgosmann (Jan Gosmann)]

I verified that MySQL is just an optional runtime dependency which can be used instead of sqlite.

Can someone commit the patch to the port tree (together with the patches of Ticket #27349 and #27348)? (I have no permissions to so. Maybe I should apply to become MacPorts committer.)

[jmroot (Joshua Root)]

r74151