Opened 14 years ago

Closed 14 years ago

#27351 closed update (fixed)

UPDATE: bcfg2 1.1.1

Reported by: sol.jerome@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: bcfg2

Description

Bcfg2 1.1.1 is available.

Attachments (2)

Portfile.diff (901 bytes) - added by sol.jerome@… 14 years ago.
Updated Portfile
patch-setup.py.diff (3.0 KB) - added by sol.jerome@… 14 years ago.
Updated setup.py patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 14 years ago by jmroot (Joshua Root)

Type: defectupdate
Version: 1.9.2

comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thank you for the update, however the patch did not apply cleanly to the current portfile in our repository. (The license line in our portfile was in a different place than your patch suggested.) In the future please supply diffs against the current portfile in our repository.

comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Also, patch says your patch-setup.py.diff is malformed.

patching file setup.py
/usr/bin/patch: **** malformed patch at line 48:  

Could you supply a new patch-setup.py.diff that patch can use?

comment:4 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Updated your maintainer email address in r73575.

Changed 14 years ago by sol.jerome@…

Attachment: Portfile.diff added

Updated Portfile

comment:5 in reply to:  2 Changed 14 years ago by sol.jerome@…

Replying to ryandesign@…:

Thank you for the update, however the patch did not apply cleanly to the current portfile in our repository. (The license line in our portfile was in a different place than your patch suggested.) In the future please supply diffs against the current portfile in our repository.

Sorry about that. It must have been updated somewhere in between (or I didn't grab it from here to begin with). Updated patch against current trunk.

Replying to ryandesign@…:

Also, patch says your patch-setup.py.diff is malformed.

patching file setup.py
/usr/bin/patch: **** malformed patch at line 48:

Could you supply a new patch-setup.py.diff that patch can use?

My fault again. That previous patch appears to be truncated. I have reattached with the proper diff. Thanks for your help!

comment:6 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Thanks. The new setup.py patch still doesn't apply though. According to the patch, it's for version 1.1.0, but you're requesting the port be updated to version 1.1.1.

Changed 14 years ago by sol.jerome@…

Attachment: patch-setup.py.diff added

Updated setup.py patch

comment:7 in reply to:  6 Changed 14 years ago by sol.jerome@…

Replying to ryandesign@…:

Thanks. The new setup.py patch still doesn't apply though. According to the patch, it's for version 1.1.0, but you're requesting the port be updated to version 1.1.1.

Ugh, this is where it'd help to have a Mac to test this on. Updated patch to apply cleanly against a checkout of bcfg2 1.1.1:

$ cd bcfg2-1.1.1/
$ patch -p0 < patch-setup.py.diff 
patching file setup.py

Sorry about all the hassle.

comment:8 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

Thanks, updated in r73577. I also added "supported_archs noarch" because this port does not appear to install any architecture-specific files.

Note: See TracTickets for help on using tickets.