multimedia/mkvtoolnix upgrade version from 4.4.0 to 4.5.0

[rmstonecipher@…]

Ruud,
mkvtoolnix 4.5.0 is available and builds fine on OS X 10.6 +universal.
Also, the file which had to be patched in version 4.4.0 was fixed upstream.
Attached is a patch to the Portfile to apply the upgrade.
With your approval of and/or revisions to that patch I will commit the change.

Cheers,
Ryan Stonecipher

[ruud@…]

The patch looks fine to me.

[anddam (Andrea D'Amore)]

The patched 4.5.0 Portfile can't build on my system using +wxwidgets, it breaks while linking mkvmerge.

This happens with unpatched 4.4.0 too, I didn't opened a ticket for it as the port is likely to be updated soon.

Here's the relevant part:

    LINK src/mkvmerge
Undefined symbols:
  "___lzo_init_v2", referenced from:
      lzo_compressor_c::lzo_compressor_c()in libmtxcommon.a(compression.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
shell command " cd
"/opt/local/var/macports/build/_opt_local_var_macports_sources_svn.macports.
org_trunk_dports_multimedia_mkvtoolnix/work/mkvtoolnix-4.5.0" && ./drake default
" returned error 1

I suspect a version mismatch betewen lzo and lzo2 ports due to the init_v2 reference. If this is the case then the linker's option for lzo should be patched as I've both ports installed.

Can anyone confirm +wxwidgets building correctly on his system?

[anddam (Andrea D'Amore)]

I confirm removing lzo port lets patched mkvtoolnix port to build fine.

[Kona8lend@…]

I can confirm notwithstanding +wxwidgets, that 4.5.0 works nicely for me and have noticed no regressions.

Since this 4.5.0 doesn't actually regress +wxwidgets anyways, and since it removes macports patches (ie: patches were merged upstream), I'd like to see this patch go in.

[anddam (Andrea D'Amore)]

Replying to Kona8lend@…:

I can confirm notwithstanding +wxwidgets, that 4.5.0 works nicely for me and have noticed no regressions.

Just to be clear: you built 4.5.0 +wxwidgets with lzo port installed, right?

My point is that the concurrent presence of both lzo and lzo2 breaks building, without lzo I'm able to build fine too.

[Kona8lend@…]

Replying to and.damore@…:

Replying to Kona8lend@…:

I can confirm notwithstanding +wxwidgets, that 4.5.0 works nicely for me and have noticed no regressions.

Just to be clear: you built 4.5.0 +wxwidgets with lzo port installed, right?

My point is that the concurrent presence of both lzo and lzo2 breaks building, without lzo I'm able to build fine too.

Clarification: i do NOT build with +wxwidgets. But as you've pointed out, this patch is not a regression; as the 4.4.0 portfile has the same lzo/lzo2 +wxwidgets issue.

[rmstonecipher@…]

lzo (LZO 1.x) has not been updated since 2002.
lzo2 (LZO 2.x) is actively developed.
I am in the process of contacting maintainers of ports which depend upon lzo to see if it is possible to update those ports to use lzo2.

Cheers,
Ryan

P.S. An alternative option may be to update lzo to the current version then edit lzo2 to be replaced_by lzo.

[ruud@…]

This is fixed in the proposed mkvtoolnix-4.6.0 Portfile; this ticket can be closed.

[anddam (Andrea D'Amore)]

Ticket outdated by 4.6.0 upgrade in #28747