caml-graph @1.3 upgrade to version 1.6

[fh@…]

Current version (1.3) fails during the destroot phase (see ticket #26091). I have attached files that upgrade to version 1.6. It fixes the bug at the same time.

[fh@…]

Portfile patch

[ryandesign (Ryan Carsten Schmidt)]

Your diff is difficult to evaluate and accept. You claim your patch updates the port to version 1.6, but you also make all sorts of unrelated changes that I don't understand:

• you remove the detailed long_description
• you change "maintainers nomaintainer" (which is correct) to just "maintainers" (which is invalid)
• you remove the slash at the end of the homepage and master_sites, making them uncanonical (not a major problem, but certainly less correct than before)
• you move various lines around, like the distname and livecheck lines
• you change the name of the patchfile from "patch-Makefile.in.diff" (our patchfile preferred format) to "patch-Makefile.in"
• you disable the universal variant (this change is probably correct, but not particularly related to updating the port to 1.6, is it?)

Perhaps you could attach a patch that only updates the port to 1.6 (including updating the patch contents along with it, if applicable, and other portfile changes that directly relate to updating to 1.6). If you have other changes you'd like done to the port, such as reformatting, we could handle those separately later.

[fh@…]

Replying to ryandesign@…:

Thanks for all you comments. I have attached new patches that hopefully match the requirements. Some important points:

• I have updated to version 1.7 that went out yesterday. The new version fixes a bug in Makefile.in that makes my previous patch to Makefile.in irrelevant.
• My previous patch to Portfile was totally wrong as the files were not destrooted but installed directly in the macports tree. I went back to the building process of version 1.3. Still my new patch to Makefile.in differs from the current one (@1.3) as ocamlfind was not invoked correctly in case LABLGNOMECANVAS was selected.

• you disable the universal variant (this change is probably correct, but not particularly related to updating the port to 1.6, is it?)

I believe it should be inherited from the caml port, but I agree it has nothing to do in that particular update.

[fh@…]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Replying to fh@…:

• you disable the universal variant (this change is probably correct, but not particularly related to updating the port to 1.6, is it?)

I believe it should be inherited from the caml port, but I agree it has nothing to do in that particular update.

Ah yes, ocaml doesn't have a universal variant, so caml-graph shouldn't either. I made this change in r78984.

[ryandesign (Ryan Carsten Schmidt)]

Replying to fh@…:

• I have updated to version 1.7 that went out yesterday.

Thanks, I've updated the port in r78985.