Opened 14 years ago

Closed 13 years ago

#29090 closed submission (fixed)

py27-pyfits: Portfile submission

Reported by: smaret (Sebastien Maret) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 1.9.2
Keywords: Cc: robitaille@…
Port: py27-pyfits

Description

Attached is a Portfile for PyFITS, a Python interface to FITS formatted file.

​http://www.stsci.edu/resources/software_hardware/pyfits

Sébastien

Attachments (2)

Portfile​ (1.0 KB) - added by smaret (Sebastien Maret) 14 years ago.
Portfile for PyFITS
Portfile.2​ (1.3 KB) - added by ryandesign (Ryan Carsten Schmidt) 14 years ago.
my proposal

Download all attachments as: .zip

Change History (11)

Changed 14 years ago by smaret (Sebastien Maret)

Attachment: Portfile​ added

Portfile for PyFITS

comment:1 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Port: py27-pyfits added
Summary: Portfile submission: PyFITS → py27-pyfits: Portfile submission

comment:2 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: new → assigned

Thanks. Do you mind if we change the port name to py27-fits?

comment:3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Here's my proposed portfile, in which I:

  • change name to py27-fits
  • adjust whitespace and add modeline
  • drop revision line
  • remove md5 checksum
  • fix numpy dependency (this is py27-fits so it needs to depend on py27-numpy not py26-numpy)
  • depends_lib-append instead of depends_lib to avoid overwriting the portgroup's dependencies
  • added supported_archs noarch

comment:4 in reply to:  3 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Replying to ryandesign@…:

  • added supported_archs noarch

This turns out to have been false, and I've removed it from the attachment.

See also #26839 for the request for the py26 version of the port.

Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: Portfile.2​ added

my proposal

comment:5 Changed 14 years ago by ryandesign (Ryan Carsten Schmidt)

I've attached a new proposal which incorporates ideas from #26839 to fix the livecheck. I also deleted the build.target which seems unnecessary. #26839 lists distribute as a dependency, but I'm not sure it's actually needed; confirmation from someone more familiar with python would be appreciated.

comment:6 in reply to:  3 Changed 14 years ago by smaret (Sebastien Maret)

Replying to ryandesign@…:

Here's my proposed portfile, in which I:

  • change name to py27-fits

Thanks for the revision. It looks good to me, except perhaps for the name change. The name of this package is PyFITS, not FITS. The name py27-fits may confuse users that are searching for pyfits, because "port search pyfits" won't find it. Unless there is a MacPort policy that encourage developer dropping the "py" in Python packages, I would rather have the package named py27-pyfits.

comment:7 in reply to:  5 Changed 14 years ago by smaret (Sebastien Maret)

Replying to ryandesign@…:

#26839 lists distribute as a dependency, but I'm not sure it's actually needed; confirmation from someone more familiar with python would be appreciated.

I don't think that distribute is needed. I don't have it installed and pyfits compiles and run fine for me. Also this module is not imported anywhere in pyfits; it uses the standard distutils module.

comment:8 Changed 14 years ago by marshall.perrin@…

I strongly concur with Sebastian that the name of this package should remain 'pyfits' since that is the official name of the package that every user will expect to find it under.

And yes, distribute is not required.

comment:9 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: robitaille@… added
Resolution: → fixed
Status: assigned → closed

Very good, I've added py27-pyfits in r79102. Sorry for the delay; thanks to Thomas Robitaille for reminding me to address this ticket.

Note: See TracTickets for help on using tickets.