gtk-quartz-engine port

[tael67@…]

I have created a port for gtk-quartz-engine (a native OSX theme for GTK). This is my first port so it may not be perfect.

[tael67@…]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Thanks, I'll commit this and provide some feedback.

FYI, you don't need to be in Cc when you're the reporter.

[ryandesign (Ryan Carsten Schmidt)]

I thought I was going to commit it, but I cannot get it to build; I get this error:

Undefined symbols:
  "_gdk_quartz_drawable_get_context", referenced from:
      _get_context in quartz-style.o
      _quartz_draw_button in quartz-draw.o
  "_gdk_quartz_drawable_release_context", referenced from:
      _release_context in quartz-style.o
      _quartz_draw_button in quartz-draw.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[2]: *** [libquartz.la] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

I thought this might've been because I was building x86_64 (I'm on Snow Leopard) and the port description mentioned Carbon and 32-bit, but adding the line "supported_archs i386 ppc" to force a 32-bit build did not change the build error.

I'm attaching a revised portfile with these changes:

• fixed whitespace (tabs to spaces, removed trailing whitespace -- see "port lint --nitpick")
• added blank lines to increase readability
• tweaked descriptions
• removed md5 checksums (we're gradually removing md5 from macports)
• used a local patchfile instead of downloading it from some web site, thus no longer need to list its checksums or patchsites
• removed post-install block which copied a template gtkrc file into the user's home directory (ports should not touch the home directory or usually anything outside of ${workpath} or ${destroot}). Instead the portfile should copy the template gtkrc file somewhere into destroot where the user can get to it later (if the makefile doesn't already do that), then use the notes feature to inform the user they should copy this file (I've included an example of this in the new portfile, though I haven't put the path to the template gtkrc file since I don't know where if anywhere it gets installed)

[ryandesign (Ryan Carsten Schmidt)]

Ryan's revised portfile proposal

[tael67@…]

Updated portfile

[ryandesign (Ryan Carsten Schmidt)]

I just noticed that you attached revised files. Please always add a comment when you attach a file, because Trac sends email notifications for comments, but not for file attachments.

[ryandesign (Ryan Carsten Schmidt)]

Previously, your autogen.sh patch was removing this line:

srcdir/configure --enable-maintainer-mode "$@"

This seemed like the correct thing to do. Your new patch no longer removes this line. Why this change? There's no need for autogen.sh to call configure, since MacPorts will do so. And there's no need to enable maintainer mode. configure --help says this option "enable[s] make rules and dependencies not useful (and sometimes confusing) to the casual installer" so that doesn't sound like something we want.

[rudloff@…]

Oops, that's an oversight.

[rudloff@…]

Here is the correct patch.

[ryandesign (Ryan Carsten Schmidt)]

Sorry I forgot about this ticket. After some more fixes, it builds for me on Mountain Lion, so I committed it in r99388.

• I had to update the autogen.sh patch for automake 1.12.
• I had to add a patch for Makefile.am to disable -Werror since clang had a (very valid) complaint about a variable being used uninitialized.
• I changed the checksums from sha1/rmd160 to rmd160/sha256.
• I made the port use the github portgroup.
• I added dependencies on libpng and libffi since when those get updated, which happens not infrequently, all ports using them need to be rebuilt, and listing the dependencies explicitly (despite the fact that they're already listed indirectly via gtk2) lets us find these ports easily.
• I reworded the pre-configure error message slightly.