Opened 13 years ago
Closed 13 years ago
#31588 closed update (fixed)
grisbi @0.6.0 update to version 0.8.8
Reported by: | gerald@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.0.3 |
Keywords: | haspatch maintainer | Cc: | dbevans (David B. Evans) |
Port: | grisbi |
Description
Update Portfile to version 0.8.8 of Grisbi.
Attachments (3)
Change History (8)
Changed 13 years ago by gerald@…
Attachment: | Portfile-grisbi.diff added |
---|
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Keywords: | haspatch maintainer added |
---|---|
Owner: | changed from macports-tickets@… to ryandesign@… |
Port: | grisbi added |
Status: | new → assigned |
comment:2 Changed 13 years ago by dbevans (David B. Evans)
Since this has been sitting for a while, here is an updated patch for the Portfile for review and comment by both of you (see attached)
- remove configure.args that are either the default or no longer recognized
- add --disable-silent-rules to make debugging easier
- add build dependencies on pkgconfig and intltool which are required
- convert lib-style lib dependencies to port dependencies to ensure only using MacPorts versions of these libraries
- remove universal_variant yes -- this is the default
- remove supported archs statement since there doesn't seem to be any restriction on arch
- fix livecheck
- add license
Ryan may have some other suggestions
Changed 13 years ago by dbevans (David B. Evans)
Attachment: | patch-grisbi-Portfile.diff added |
---|
Revised patch for Portfile
comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Sorry, I forgot about this. Additional comments:
master_sites sourceforge
should be rewritten to avoid redirects- the no_ofx variant should be deprecated and turned into an on-by-default ofx variant; the no_ofx variant can be deleted in a year or so once everyone has upgraded to this new version
- the livecheck should be able to discover new stable branches of the software
- we prefer rmd160 & sha256 checksum types
I've attached a new update, which is almost ready, except that grisbi has a bug where it will use ofx, even if you ask it not to; I filed upstream bug 1432 about this.
Ideally I'd also like to make a second commit later to fix the port's whitespace and formatting to conform to the modeline and our usual formatting practices.
Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | grisbi-ryandesign.diff added |
---|
proposed patch
comment:5 Changed 13 years ago by raimue (Rainer Müller)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Committed proposed patch in r90310.
Note: See
TracTickets for help on using
tickets.
Thanks. There are several changes I'd suggest. I'll attach a new patch and explain and you can see what you think.