Opened 13 years ago
Closed 13 years ago
#33004 closed defect (duplicate)
sox @14.3.2 update - fix hidden dependencies
Reported by: | janstary (Jan Starý) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.0.3 |
Keywords: | haspatch maintainer | Cc: | ryandesign (Ryan Carsten Schmidt) |
Port: | sox |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
Attached is a diff to to audio/sox which
- fixes checksums
- changes the description to the author's original
- fixes a hidden dependency on audio/opencore-amr
- fixes a hidden dependency on audio/lame
- fixes a hidden dependency on audio/libogg
- fixes a hidden dependency on archivers/zlib
- fixes a hidden dependency on textproc/libiconv
- gives explicit ./configure args to prevent further hidden deps
- drops needless dependency on libao (we use coreaudio of course)
- drops dependency on libsamplerate which the build does not pick up, and doesn't have an explicit ./configure arg for
- drops the dependency on ffmpeg, which in turn depends on the whole xorg-* world, thus turning a neat little audio app into a monstrous dependency hog; the ffmpeg build is left as a variant
Attachments (1)
Change History (9)
comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | david@… removed |
---|---|
Description: | modified (diff) |
Keywords: | haspatch added |
Owner: | changed from macports-tickets@… to david@… |
comment:2 Changed 13 years ago by janstary (Jan Starý)
Better diff attached:
dist_subdir
used for the stealth-updated distfile- modeline restored
- as suggested at the list, ffmpeg is put back (but remains problematic, currently discussed upstream)
comment:3 Changed 13 years ago by janstary (Jan Starý)
Yet another diff - the checksum change is in fact *not* due to stealth update, but simply because it's the gz checksum, not the bz2 checksum. Sorry for the confusion.
Changed 13 years ago by janstary (Jan Starý)
Attachment: | Portfile.diff added |
---|
comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)
In that case I should ask: why switch from a bz2 distfile to a gz distfile? We prefer bz2 distfiles because they are smaller.
comment:5 Changed 13 years ago by jmroot (Joshua Root)
Cc: | ryandesign@… added |
---|---|
Keywords: | maintainer added |
Owner: | changed from david@… to macports-tickets@… |
comment:6 Changed 13 years ago by raimue (Rainer Müller)
The provided patch does not apply cleanly anymore. Please provide a patch against the current version.
comment:7 Changed 13 years ago by janstary (Jan Starý)
This is obsoleted by the recent update to 14.4.0, commited in https://trac.macports.org/changeset/90444
comment:8 Changed 13 years ago by drkp (Dan Ports)
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
You cannot simply change the checksums. See wiki:PortfileRecipes#stealth-updates.
The modeline should not be removed; instead, the portfile's whitespace should be modified to conform to the modeline and our usual formatting guidelines, and these changes should be made separately from any functional changes.