samtools @0.1.17 fix - respect build_arch

[mg13@…]

This patch ensures the correct macports-calculated CFLAGS propagate to the make, thus allowing correct building when build_arch &/or macosx_deployment_target are set.

It's a bit of a hack but seems to work - there may be a more 'approved' way of doing this.

[ryandesign (Ryan Carsten Schmidt)]

I agree, that does look very hacky, and I would look for a different way to do it that is more similar to the way we've done it in other ports. At the same time, adding support for a universal variant would be a good idea. The [get_canonical_archflags] procedure will likely be useful.

[mg13@…]

Patch for samtools Portfile

[mg13@…]

samtools Makefile patch

[mg13@…]

Replying to ryandesign@…:

I agree, that does look very hacky, and I would look for a different way to do it that is more similar to the way we've done it in other ports. At the same time, adding support for a universal variant would be a good idea. The [get_canonical_archflags] procedure will likely be useful.

Okay, I've just uploaded a new version which uses [get_canonical_archflags]. I'm afraid I haven't got time to investigate a universal variant right now.

This now also updates the samtools version to 0.1.18.

Michael

[jmroot (Joshua Root)]

r96081