#33575 closed submission (fixed)
NEW: stimfit
| Reported by: | neurodroid (Christoph Schmidt-Hieber) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | neurodroid (Christoph Schmidt-Hieber), flyamer@…, sjm.guzman@…, neurohost@…, janina.kowalski@…, c.wilms@…, vanesalluna@…, doreenmilius@…, sanja.mikulovic@…, helensaad@…, ci42, cooljeanius (Eric Gallager) | |
| Port: | stimfit |
Description
It's in the Debian repositories, if that is relevant at all: http://packages.debian.org/sid/stimfit
Attachments (2)
Change History (25)
Changed 13 years ago by neurodroid (Christoph Schmidt-Hieber)
comment:1 follow-up: 2 Changed 13 years ago by mf2k (Frank Schima)
| Port: | stimfit added |
|---|---|
| Version: | 2.0.4 |
Looks good but I have a few comments:
- It is preferable if you allow the user to choose the python version by making variants for python26, python27, python31, etc. You can make python27 the default. See the inkscape port for an example.
- Use
${applications_dir} instead of hardcoding/Applications/Macportsin post-destroot.
comment:2 Changed 13 years ago by neurodroid (Christoph Schmidt-Hieber)
Thanks for your review.
Replying to macsforever2000@…:
Looks good but I have a few comments:
- It is preferable if you allow the user to choose the python version by making variants for python26, python27, python31, etc. You can make python27 the default. See the inkscape port for an example.
There's no python26 port for wxpython-devel yet. I've started a ticket (#33590). Pending its acceptance, the python26 variant is commented out.
- Use
${applications_dir} instead of hardcoding/Applications/Macportsin post-destroot.
Done. The app bundle now gets installed to ${destroot}${applications_dir} so that uninstall can clean up properly.
Changed 13 years ago by neurodroid (Christoph Schmidt-Hieber)
| Attachment: | Portfile.2 added |
|---|
stimfit Portfile
comment:3 Changed 12 years ago by jmroot (Joshua Root)
| Summary: | stimfit → NEW: stimfit |
|---|
comment:4 Changed 12 years ago by neurodroid (Christoph Schmidt-Hieber)
Stimfit now uses wxWidgets30 and py27-wxpython30:
https://stimfit.googlecode.com/git/macosx/macports/science/stimfit/Portfile
Let me know what remains to be done to get this included into MacPorts.
comment:17 follow-up: 20 Changed 11 years ago by ci42
Before including into MacPorts some questions and remarks:
license GPL
- Can you indicate the version (e.g. GPL-2)?
supported_archs x86_64
- really no i386 and PowerPC? The debian repository you mentioned provides packages for both.
if {![variant_isset python27]} {
default_variants +python27
}
- The
default_variantsshould not be inside a if block. This idiom makes only sense if you have more than on python variant and would like to make one the default if none had explicitly chosen by the user.
variant python27 description {Build with Python shell. Only 2.7 is supported.}
Only 2.7 is supportedshould not be in the variant description but moved to a comment.
comment:20 follow-up: 21 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)
Thanks for your review.
Replying to ciserlohn@…:
Before including into MacPorts some questions and remarks:
license GPL
- Can you indicate the version (e.g. GPL-2)?
Fixed in r5ed64d7830c3.
supported_archs x86_64
- really no i386 and PowerPC? The debian repository you mentioned provides packages for both.
Added i386 in r5ed64d7830c3. File I/O depends on endianness and OS; including ppc would require some thorough testing.
if {![variant_isset python27]} { default_variants +python27 }
- The
default_variantsshould not be inside a if block. This idiom makes only sense if you have more than on python variant and would like to make one the default if none had explicitly chosen by the user.
Commented out in r5ed64d7830c3, pending availability of wxPython for Python 3.x.
variant python27 description {Build with Python shell. Only 2.7 is supported.}
Only 2.7 is supportedshould not be in the variant description but moved to a comment.
Fixed in r5ed64d7830c3.
Some additional fixes to address relevant issues from comment:ticket:37471:18 were added in r609ada02fd6a and r45f538cbfddc.
comment:21 follow-up: 22 Changed 11 years ago by ci42
Replying to christsc@…:
Thanks for your review.
Replying to ciserlohn@…:
Before including into MacPorts some questions and remarks:
license GPL
- Can you indicate the version (e.g. GPL-2)?
Fixed in r5ed64d7830c3.
(...)
Some additional fixes to address relevant issues from comment:ticket:37471:18 were added in r609ada02fd6a and r45f538cbfddc.
Probably this is also an issue here (though I haven't tested it).
comment:22 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)
Replying to ciserlohn@…:
[...]
Probably this is also an issue here (though I haven't tested it).
Fixed in r948c6eac5c8a
stimfit Portfile