NEW: py-stfio

[neurodroid (Christoph Schmidt-Hieber)]

py-stfio is a Python module to read common electrophysiology file formats. It's been available in the Debian repositories for quite a while now (​http://packages.debian.org/sid/python-stfio). Portfile is available here: ​https://stimfit.googlecode.com/git/macosx/macports/python/py-stfio/Portfile

Thanks for your consideration.

[ryandesign (Ryan Carsten Schmidt)]

Oh sorry, it is a submission; I initially only saw that there was no attachment in this ticket and overlooked the URL.

Some questions and comments about the port at the URL:

• "license GPL": Can you indicate the license version(s)? e.g. "GPL-2" or maybe "GPL-3+".
• "master_sites https://stimfit.googlecode.com/files/ file:///Users/cs/stimfit/build/release/": "master_sites googlecode:stimfit" is preferred; listing a file:/// URL in master_sites doesn't make sense
• "supported_archs x86_64 i386": for what reason does this software not work on PowerPC?
• "python.default_version 27" can be omitted because that is the default
• "configure.args PYTHON=${python.bin}": "configure.python ${python.bin}" is preferred
• "depends_lib port:swig-python": is it really a library dependency? Usually swig is only used at build time, to build some kind of language bindings.

[neurodroid (Christoph Schmidt-Hieber)]

Thanks for your review. All addressed in ​https://code.google.com/p/stimfit/source/detail?r=a3f9b9be56d8

Replying to ryandesign@…:

Some questions and comments about the port at the URL:

• "license GPL": Can you indicate the license version(s)? e.g. "GPL-2" or maybe "GPL-3+".

Fixed.

• "master_sites https://stimfit.googlecode.com/files/ file:///Users/cs/stimfit/build/release/": "master_sites googlecode:stimfit" is preferred; listing a file:/// URL in master_sites doesn't make sense

How neat is that. Fixed.

• "supported_archs x86_64 i386": for what reason does this software not work on PowerPC?

It hasn't been tested on ppc, and there's good reason to believe that big endianness may cause trouble.

• "python.default_version 27" can be omitted because that is the default

Fixed.

• "configure.args PYTHON=${python.bin}": "configure.python ${python.bin}" is preferred

Fixed.

• "depends_lib port:swig-python": is it really a library dependency? Usually swig is only used at build time, to build some kind of language bindings.

Fixed.

The updated Portfile is available here: ​https://stimfit.googlecode.com/git/macosx/macports/python/py-stfio/Portfile

[neurodroid (Christoph Schmidt-Hieber)]

Cc Me!

[flyamer@…]

Cc Me!

[sjm.guzman@…]

Cc Me!

[sjm.guzman@…]

Cc Me!

[sjm.guzman@…]

Cc Me!

[neurohost@…]

Cc Me!

[neurohost@…]

Cc Me!

[neurohost@…]

Cc Me!

[janina.kowalski@…]

Cc Me!

[c.wilms@…]

Cc Me!

[vanesalluna@…]

Cc Me!

[doreenmilius@…]

Cc Me!

[sanja.mikulovic@…]

Cc Me!

[helensaad@…]

Cc Me!

[ci42]

Some remarks:

• as the software is licensed under the GPL the port should include a copy in ${prefix}/share/doc/py-stfio/ (see ​https://www.gnu.org/licenses/gpl-faq.html#WhyMustIInclude).
• there are no .pyc files included. Most py-* ports include them because they can't be generated afterwards (the installation directory is typically read-only for ordinary users).
• the debian packages includes hdf5tools.py. The port does not (I don't know if this is revelvant).

[ci42]

Cc Me!

[cooljeanius (Eric Gallager)]

Cc Me!

[neurodroid (Christoph Schmidt-Hieber)]

Thanks for your review.

Replying to ciserlohn@…:

Some remarks:

• as the software is licensed under the GPL the port should include a copy in ${prefix}/share/doc/py-stfio/ (see ​https://www.gnu.org/licenses/gpl-faq.html#WhyMustIInclude).

Fixed in ​r45f538cbfddc.

• there are no .pyc files included. Most py-* ports include them because they can't be generated afterwards (the installation directory is typically read-only for ordinary users).

Fixed in ​r609ada02fd6a. This is useful for other platforms as well.

• the debian packages includes hdf5tools.py. The port does not (I don't know if this is revelvant).

hdf5tools.py should not be part of the latest versions of py-stfio.

[ci42]

Replying to christsc@…:

Thanks for your review.

Replying to ciserlohn@…:

Some remarks:

• as the software is licensed under the GPL the port should include a copy in ${prefix}/share/doc/py-stfio/ (see ​https://www.gnu.org/licenses/gpl-faq.html#WhyMustIInclude).

Fixed in ​r45f538cbfddc.

The port now installs ${prefix}/share/doc/py27-stfio/copyright which is good, but it does not include the full text of the GPL:

On Debian systems, the full text of the GNU General Public
License version 2 can be found in the file
`/usr/share/common-licenses/GPL-2'.

We're not on debian so the aforementioned file does not exists. Please include a full text version of the GPL.

Apart from that I think the port is ready for inclusion.

[neurodroid (Christoph Schmidt-Hieber)]

Replying to ciserlohn@…:

Replying to christsc@…:

Thanks for your review.

Replying to ciserlohn@…:

Some remarks:

• as the software is licensed under the GPL the port should include a copy in ${prefix}/share/doc/py-stfio/ (see ​https://www.gnu.org/licenses/gpl-faq.html#WhyMustIInclude).

Fixed in ​r45f538cbfddc.

The port now installs ${prefix}/share/doc/py27-stfio/copyright which is good, but it does not include the full text of the GPL:

On Debian systems, the full text of the GNU General Public
License version 2 can be found in the file
`/usr/share/common-licenses/GPL-2'.

We're not on debian so the aforementioned file does not exists. Please include a full text version of the GPL.

Fixed in ​r948c6eac5c8a. This also addresses the ​remaining comment in ticket #33575.

Apart from that I think the port is ready for inclusion.

Thanks

[ci42]

r107428