Opened 12 years ago
Closed 12 years ago
#34969 closed defect (fixed)
pianobar: update to 2012.06.24
| Reported by: | aguynamedryan+macports@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.1 |
| Keywords: | haspatch maintainer | Cc: | |
| Port: | pianobar |
Description
pianobar has released an update
Attachments (5)
Change History (9)
Changed 12 years ago by aguynamedryan+macports@…
| Attachment: | patch-Makefile.diff added |
|---|
Changed 12 years ago by aguynamedryan+macports@…
| Attachment: | pianobar-2012.06.24.diff added |
|---|
patches for Portfile
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Status: | new → assigned |
Thanks!
Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Upgrading the port fails. I've attached the main.log.
Changed 12 years ago by aguynamedryan+macports@…
| Attachment: | working_main.log added |
|---|
main.log when building pianobar works
Changed 12 years ago by aguynamedryan+macports@…
| Attachment: | pianobar-2012.06.24.2.diff added |
|---|
patches for Portfile
comment:3 Changed 12 years ago by aguynamedryan+macports@…
From what I can tease out from your log, line 264 has an error:
:info:build src/settings.h:87: error: expected specifier-qualifier-list before ‘PianoAudioQuality_t’
As with most GCC errors, this one is cryptic, but can mean "I don't know what PianoAudioQuality_t is".
Line 90 of your log seems to be including piano.h from /opt/local/include/piano.h instead of from src/libpiano/piano.h If that is the case, /opt/local/include/piano.h won't define PianoAudioQuality_t because PianoAudioQuality_t was added in this latest release.
I've attempted to update the Portfile to include "-I. -I./src/libpiano/" to try to pull the local copy of piano.h instead of your system's outdated piano.h file. Hopefully it works. Failing that, hopefully I've given you enough to tinker around with to cajole this thing into compiling.
comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Also, the patch you had attached here had lost some of the changes we had made before. I reinstated them before committing.
patches for Makefile