Opened 12 years ago
Closed 12 years ago
#35389 closed defect (fixed)
nodejs, nodejs-devel: use MacPorts CXXFLAGS
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | ci42 |
|---|---|---|---|
| Priority: | Low | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | haspatch | Cc: | |
| Port: | nodejs, nodejs-devel |
Description
Currently the nodejs and nodejs-devel portfiles pass CFLAGS to the build phase but not CXXFLAGS. node defaults to building with -O3, while MacPorts CFLAGS and CXXFLAGS contain ${configure.optflags} which defaults to -O2. The upshot of this combination of facts is that the C parts of node are getting built with -O2 while the CXX parts are getting built with -O3. This difference was probably not intended.
I propose the attached patch to pass CXXFLAGS as well. This way everything will be built with MacPorts default -O2. If a different optimization setting is desired, configure.optflags can additionally be set.
Attachments (1)
Change History (2)
Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | nodejs-cxxflags.diff added |
|---|
comment:1 Changed 12 years ago by ci42
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Done in r96197 and r96198.