Opened 12 years ago
Closed 12 years ago
#35388 closed defect (fixed)
arb Patches for Mountain Lion 10.8
| Reported by: | mattcottrell | Owned by: | drkp (Dan Ports) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | maintainer haspatch mountainlion | Cc: | |
| Port: | arb |
Description
arb Patches for Mountain Lion 10.8
Attachments (4)
Change History (15)
Changed 12 years ago by mattcottrell
| Attachment: | Portfile.diff added |
|---|
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
You probably shouldn't depend on port:xorg; you should depend on the specific xorg ports that you actually need.
comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Maybe I should ask: why are you adding the xorg dependency on Mountain Lion only? Is it because Mountain Lion does not include X11 anymore? If so, then I don't think adding additional xorg dependencies is correct. The user could either install the xorg-server port, or install XQuartz; either would be fine (just as on previous versions of OS X, the user could use the xorg-server port, XQuartz, or the X11 Apple included). So I don't think we should now force the user to use xorg-server.
comment:3 Changed 12 years ago by mattcottrell
That's right, I was dealing with Mountain Lion not supplying X11.
What is the best way to head off novice users installing arb on Mountain Lion only to get the "Cannot open display" error the first time they try to run arb?
I could add instructions to the port notes directing folks to install xorg-server and quartz-wm or XQuarz, I suppose.
Changed 12 years ago by mattcottrell
| Attachment: | Portfile.2.diff added |
|---|
Revised Portfile does not install xorg
comment:5 Changed 12 years ago by mattcottrell
I should have given this ticket a more informative title. It solves a build error seen with Mountain Lion:
Error: reinplace: sed: RE error: illegal byte sequence Error: org.macports.configure for port arb returned: reinplace sed(1) failed
The attached portfile diff solves the problem by eliminating the need to reinplace sed for gsed and using coreutils instead.
comment:6 Changed 12 years ago by mattcottrell
The arb port will not build on Mountain Lion without this Portfile patch, at least not for me.
comment:7 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | mountainlion added |
|---|
I don't quite understand the patch... what component of coreutils is arb using, and how does that relate to whether you use sed or gsed?
FYI there's nothing wrong with using reinplace to change "sed" to "gsed", except that the sed that reinplace runs needs to know what character encoding the files use. It assumes UTF-8, but at least one of the files you're reinplacing is not UTF-8. So you have to tell it a suitable locale. The locale "C" is ofter suitable, and that is what we have been using in other ports to fix this error:
reinplace locale -C ...
comment:8 Changed 12 years ago by mattcottrell
Revised Portfile.diff using "reinplace -locale C" now builds on Mountain Lion.
Note the misplaced "-" in the previous comment, vis-a-vie:
reinplace -locale C ...
Changed 12 years ago by mattcottrell
| Attachment: | Portfile.3.diff added |
|---|
Now using reinplace -locale C
comment:9 Changed 12 years ago by mattcottrell
Now I'm receiving email from arb users who are experiencing build failures with Mountain Lion. Can I get a thumbs up on my patch and a commit to satisfy them?
comment:10 Changed 12 years ago by drkp (Dan Ports)
| Owner: | changed from macports-tickets@… to dports@… |
|---|---|
| Status: | new → assigned |
comment:11 Changed 12 years ago by drkp (Dan Ports)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Thanks, committed in r96547.
I left out the revision bump; because the problem was a build error, it shouldn't be necessary to force people who already have the port installed to rebuild.
Portfile diff