Opened 12 years ago
Closed 12 years ago
#36316 closed defect (fixed)
splash @2.1.1 +hdf5 - build failure
| Reported by: | danieljprice (Daniel Price) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | haspatch maintainer | Cc: | wd11@…, ryandesign (Ryan Carsten Schmidt) |
| Port: | splash |
Description
Hi folks,
I discovered an issue with the splash Portfile for the hdf5 variant (fails to build)
Essentially, should depend on hdf5-18 not hdf5
Portfile.diff that fixes this attached
Only thing I'm not sure of is whether I need to bump a revision number if only the Portfile has changed?
Cheers,
Daniel
Attachments (1)
Change History (2)
Changed 12 years ago by danieljprice (Daniel Price)
| Attachment: | Portfile-splash.diff added |
|---|
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | wd11@… ryandesign@… added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
The question of whether to increase the revision is answered by asking yourself: does the port build but not run correctly? If so, increate the revision when making the change. Or does the port not build? If so, no revision increase is necessary. Since this problem resulted in a build failure, I committed the change in r98311 without a revision increase.
When reporting a build failure, it's best to include the build error messages in the ticket description or attach a main.log showing the failure (as was done in duplicate #36417); that way we can verify that the patch fixes the problem.