jgraph-8.3 fails to compile with clang

[brett.higgins@…]

Short version: clang doesn't like old-style C function definitions. configure.cc gives clang on Mountain Lion (maybe on others?), so jgraph fails to compile.

Lots of warnings like this:

edit.c:683:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
edit_hash_label(a)
^~~~~~~~~~~~~~~

and resulting errors like this:

edit.c:700:40: error: non-void function 'edit_hash_label' should return a value [-Wreturn-type]
        if ((s = getlabel()) == CNULL) return;
                                       ^

Adding

configure.compiler   gcc

to the Portfile resolves the issue. (Alternative fix would be to patch all the old-style definitions; obviously more laborious.)

[ryandesign (Ryan Carsten Schmidt)]

Replying to brett.higgins@…:

configure.cc gives clang on Mountain Lion (maybe on others?)

On Xcode 4.2 and up.

Adding

configure.compiler   gcc

to the Portfile resolves the issue. (Alternative fix would be to patch all the old-style definitions; obviously more laborious.)

compiler.blacklist clang

is what we would want to put, if we cannot fix it to compile with clang.

[stevecheckoway (Stephen Checkoway)]

I've uploaded a bunch of patches that allow jgraph to be compiled without error.

The new Portfile should fix ticket #36405 as well.

I've also changed my email address to match what I use for trac.

[mf2k (Frank Schima)]

Please instead attach a unified diff of the portfile so we can see what changes you made.

[stevecheckoway (Stephen Checkoway)]

Replying to macsforever2000@…:

Please instead attach a unified diff of the portfile so we can see what changes you made.

Done.

[ryandesign (Ryan Carsten Schmidt)]

Replying to s@…:

The new Portfile should fix ticket #36405 as well.

I applied that portion of the patch in r98258.

[ryandesign (Ryan Carsten Schmidt)]

Committed in r98260 and r98261.