#37343 closed enhancement (fixed)
nmap: add a "-subversion" variant
| Reported by: | irony42@… | Owned by: | opendarwin.org@… |
|---|---|---|---|
| Priority: | Low | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | danielluke (Daniel J. Luke), ryandesign (Ryan Carsten Schmidt), dogcow@…, wyuenho (Jimmy Yuen Ho Wong) | |
| Port: | nmap |
Description
nmap builds fine without subversion, albeit without an "nmap-update" feature. It would be nice to be able to forgo this dependency via a variant.
Attachments (3)
Change History (18)
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | dluke@… added |
|---|---|
| Owner: | changed from macports-tickets@… to opendarwin.org@… |
| Port: | nmap added |
| Summary: | add a "-subversion" variant to nmap → nmap: add a "-subversion" variant |
| Type: | request → enhancement |
| Version: | 2.1.2 |
comment:2 Changed 12 years ago by danielluke (Daniel J. Luke)
comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
I was working on a patch; I'll add it tomorrow.
comment:6 Changed 12 years ago by larryv (Lawrence Velázquez)
| Cc: | larryv@… added; larry.velazquez@… removed |
|---|
Changed 9 years ago by wyuenho (Jimmy Yuen Ho Wong)
| Attachment: | 37343.patch added |
|---|
This patch removes subversion dep in the default build and added a variant for that
comment:9 Changed 9 years ago by danielluke (Daniel J. Luke)
Thanks for the patch, but I don't think it actually works in the -subversion case (if subversion is installed, it will still get used). There needs to be something that forces the build to not use subversion if the variant isn't selected (so that builds are reproducible).
Changed 9 years ago by irony42@…
| Attachment: | patch2.patch added |
|---|
A patch that also works in the -subversion case
Changed 9 years ago by wyuenho (Jimmy Yuen Ho Wong)
| Attachment: | nmap.7.10_1.patch added |
|---|
Macport style hints for editor, revision and force default installation without subversion
comment:11 Changed 9 years ago by danielluke (Daniel J. Luke)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I went ahead and added +subversion as a default variant and converted the no_* variants to match the style. (r147186)
comment:12 follow-up: 13 Changed 9 years ago by wyuenho (Jimmy Yuen Ho Wong)
Why would anybody want to use the subversion variant as default? The whole point of this ticket was to get rid of it as a default dependency. nmap-update is an old closed-alpha project.
comment:13 follow-up: 14 Changed 9 years ago by danielluke (Daniel J. Luke)
Replying to wyuenho@…:
Why would anybody want to use the subversion variant as default?
maybe ask upstream why it's in the default ./configure ?
The whole point of this ticket was to get rid of it as a default dependency. nmap-update is an old closed-alpha project.
You can easily build without it now, you couldn't before.
comment:14 follow-up: 15 Changed 9 years ago by wyuenho (Jimmy Yuen Ho Wong)
Replying to dluke@…:
Replying to wyuenho@…:
Why would anybody want to use the subversion variant as default?
maybe ask upstream why it's in the default ./configure ?
That configure script also builds with ndiff, zenmap and nping, the same question could also be asked why they aren't in the requirements of this port. I think for me, I just want a default nmap package that I'd expect on a Linux distro. AFAIK, both CentOS and Ubuntu package nmap with lua by default. r147186 not only got rid of lua as a dep and not providing a variant for it, but also reenabled subversion as a default variant. I'm not sure what the reasoning for this change is. BTW, this Portfile violates Macport's coding standard. nmap has also gone on to 7.12 now.
The whole point of this ticket was to get rid of it as a default dependency. nmap-update is an old closed-alpha project.
You can easily build without it now, you couldn't before.
But that shouldn't be the default, and certainly not what this ticket was asking for.
comment:15 Changed 9 years ago by danielluke (Daniel J. Luke)
Replying to wyuenho@…:
That configure script also builds with ndiff, zenmap and nping,
zenmap/ndiff isn't built by default because of the large dependency tree (and maintainer discretion - see also #24177)
r147186 not only got rid of lua as a dep
nope it didn't change it (still builds with --with-liblua=included)
and not providing a variant for it, but also reenabled subversion as a default variant.
nope, it moved subversion to a default variant from being unconditionally required.
BTW, this Portfile violates Macport's coding standard.
Maintainers have a wide latitude for Portfile style.
nmap has also gone on to 7.12 now.
yes, it was released yesterday. I plan on updating it when I get some time.
The bug tracker is not really the place to have this conversation. If you'd like to continue, I'd suggest we move to macports-dev.
When I first looked at this, there didn't appear to be a clean way to build without subversion (but that has possibly changed with subsequent upstream releases).
If this is something you really want, it will happen faster if you can submit a patch :-)