Opened 12 years ago
Closed 10 years ago
#37352 closed update (fixed)
torsocks: Fixes for #36806 and #36807
Reported by: | sami.laine@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | ryandesign (Ryan Carsten Schmidt) |
Port: | torsocks |
Attachments (2)
Change History (8)
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign@… added |
---|---|
Description: | modified (diff) |
Keywords: | haspatch added |
Summary: | Fixes for #38606 and #36807 → torsocks: Fixes for #36806 and #36807 |
comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
- Further to the whitespace changes, you've replaced spaces, which are our preferred indentation style, with tabs. We should however make some whitespace adjustment, because our preferred style (which the portfile claims—via its modeline—to comply with) is to indent at multiples of four spaces.
- Also, since these changes change the files that are installed, the portfile's revision should be increased.
Changed 12 years ago by sami.laine@…
comment:4 Changed 12 years ago by sami.laine@…
A brand new Portfile attached incorporating most of the changes mentioned.
comment:5 Changed 12 years ago by sami.laine@…
A diff attached also, just in case a whole Portfile is not likeable.
Changed 12 years ago by sami.laine@…
Attachment: | torsocks.Portfile.diff added |
---|
comment:6 Changed 10 years ago by mf2k (Frank Schima)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Version: | 2.1.2 |
Thanks and sorry for the long delay. Committed in r124314 with the following changes:
- Did not rename OS X to "Mac OS X" because that is not the correct name.
- Did not remove the rmd160 checksum.
- Set the revision to 1 since 0 is the default value.
- Whitespace adjustments per Macports standard.
Note: See
TracTickets for help on using
tickets.
Thank you but this patch has a few problems: