Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#37590 closed update (fixed)

piklab 0.16.2

Reported by: alexgrach Owned by: jwbacon@…
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: haspatch Cc: ryandesign (Ryan Carsten Schmidt)
Port: piklab

Description


Attachments (5)

patch-src-common-port-CMakeLists.txt.diff​ (263 bytes) - added by alexgrach 12 years ago.
patch-src-common-port-port.cpp.diff​ (1.4 KB) - added by alexgrach 12 years ago.
patch-src-common-port-port.h.diff​ (308 bytes) - added by alexgrach 12 years ago.
patch-src-progs-gui-port_selector.cpp.diff​ (385 bytes) - added by alexgrach 12 years ago.
Portfile-piklab.diff​ (2.9 KB) - added by alexgrach 12 years ago.

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by alexgrach

Attachment: patch-src-common-port-CMakeLists.txt.diff​ added

Changed 12 years ago by alexgrach

Attachment: patch-src-common-port-port.cpp.diff​ added

Changed 12 years ago by alexgrach

Attachment: patch-src-common-port-port.h.diff​ added

Changed 12 years ago by alexgrach

Attachment: patch-src-progs-gui-port_selector.cpp.diff​ added

comment:1 Changed 12 years ago by alexgrach

Cc: gav@… added

Cc Me!

comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added; gav@… removed
Keywords: haspatch added; piklab qt4 kde4 removed
Owner: changed from macports-tickets@… to jwbacon@…

Some remarks:

  • this ticket supersedes #35261
  • the revision should be 0 not 1
  • does tds.net:jwbacon consent to give up maintainership of this port to you?
  • instead of setting depends_build to bin:cmake:cmake and port:pkgconfig, just append port:pkgconfig to depends_build, since the cmake portgroup that you're using already sets depends_build to port:cmake

Changed 12 years ago by alexgrach

Attachment: Portfile-piklab.diff​ added

comment:3 Changed 12 years ago by alexgrach

Yes, tds.net:jwbacon has consent to give up maintainership of this port.

comment:4 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: new → closed

Thanks. Committed in r102580 with these changes:

  • made you the maintainer
  • used "depends_build-append port:pkgconfig" instead of "depends_build port:pkgconfig" since you've added the cmake portgroup and it already sets depends_build to port:cmake, and we don't want to overwrite that.
  • some whitespace changes

comment:5 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

The buildbots failed to build it, saying: 

CMake Error at /opt/local/share/apps/cmake/modules/FindPackageHandleStandardArgs.cmake:198 (MESSAGE):
  Did not find automoc4 (Automoc4Config.cmake, install
  git://anongit.kde.org/automoc).  (missing: AUTOMOC4_EXECUTABLE)

Fixed in r102581 by adding automoc build dependency.

Note: See TracTickets for help on using tickets.