Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#37954 closed enhancement (fixed)

Cleanup whitespace in SBCL Portfile.

Reported by: crossd@… Owned by: easye
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: gwright@…
Port: sbcl

Description

Clean up whitespace and formatting in the SBCL Portfile.

Attachments (1)

Portfile.sbcl-1.1.4.whitespace.diff (6.6 KB) - added by crossd@… 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by crossd@…

comment:1 Changed 12 years ago by jmroot (Joshua Root)

Cc: gwright@… added; easieste@… removed
Owner: changed from macports-tickets@… to easieste@…
Version: 2.1.3

comment:2 Changed 12 years ago by easye

Resolution: wontfix
Status: newclosed

As I understand things, the current [MacPorts convention is to use space for whitespace, not tab characters][4.7.1], a convention that I fully support. JWZ has a [nice rant][jwz] summarizing the debate fairly succinctly from a pro-space position.

Closing the ticket as "wontfix", but I suppose there will be a little further debate.

If the "tab" side wins, one should change the autoset variables for Emacs/VIM in the headers as well.

[4.7.1] http://guide.macports.org/chunked/development.practices.html

[jwz]: http://www.jwz.org/doc/tabs-vs-spaces.html]

comment:3 Changed 12 years ago by larryv (Lawrence Velázquez)

Resolution: wontfix
Status: closedreopened

Correct, portfiles use 4-space indentation. However, on account of how ugly the sbcl portfile currently is, I’ve applied crossd’s patch and just converted the tabs to spaces.

comment:4 Changed 12 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: reopenedclosed

comment:5 Changed 12 years ago by crossd@…

Thanks! Sorry about the tabs; I thought I had run 'expand' to covert them to spaces before sending the patch, but I had not. :-/

comment:6 Changed 12 years ago by jmroot (Joshua Root)

Just to clarify, the policy is that indent style is up to the maintainer, but should be consistent throughout the file and correctly indicated in the modeline (if present). 4 spaces is recommended but not required.

Note: See TracTickets for help on using tickets.