Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#38071 closed defect (fixed)

fish @1.23.1_5 +xsel: should depend on xsel port instead of installing its own

Reported by: larryv (Lawrence Velázquez) Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: cooljeanius (Eric Gallager)
Port: fish

Description (last modified by larryv (Lawrence Velázquez))

fish +xsel currently installs ${prefix}/bin/xsel and declares a conflict with MacPorts’ xsel (see #38061). The fish port should be changed to use MacPorts’ xsel and never install its own.

Change History (6)

comment:1 Changed 12 years ago by larryv (Lawrence Velázquez)

Description: modified (diff)

comment:2 Changed 12 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:3 Changed 12 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: newclosed

I think fish just builds and installs its own copy of xsel; there’s no linking or anything. So MacPorts users can just install the xsel port at their leisure.

I’ve removed +xsel (and, by extension, the conflict with xsel) in r103145.

comment:4 Changed 12 years ago by cooljeanius (Eric Gallager)

Instead of just going and removing it right away, how about temporarily changing the variant so all it does is display a message telling users that it's deprecated and to just install the xsel port instead? Then after a while it can be removed entirely. I just know this is how some other ports handle keeping old variants for compatibility, and it would make sense to do so here, too.

comment:5 Changed 12 years ago by larryv (Lawrence Velázquez)

I added a note about xsel in r103154.

comment:6 Changed 12 years ago by cooljeanius (Eric Gallager)

Thanks.

Note: See TracTickets for help on using tickets.