py-oursql: upgrade to 0.9.3.1

[larryv (Lawrence Velázquez)]

Thanks.

[jmroot (Joshua Root)]

Does it somehow work now if you disable all the variants? If not, why remove the check?

[robsonpeixoto@…]

I did not try it. Sorry.

I removed because I made a wrong copy from py-mysql.

Need to add:

pre-configure {
        if {![variant_isset mysql4] &&
            ![variant_isset mysql5] &&
            ![variant_isset mysql51] &&
            ![variant_isset mysql55]} {
            return -code error "you must select either mysql4, mysql5, mysql51 or mysql55"
        }
    }

I you can, should be a excellent feature add py3.x support using py3k branch. ​https://launchpad.net/oursql/py3k

[stevecheckoway (Stephen Checkoway)]

Replying to robsonpeixoto@…:

I you can, should be a excellent feature add py3.x support using py3k branch.

The most recent patch added in #39510 adds support for 3.x. It's still on 0.9.2, although the change for 0.9.3 is likely minor. I'm unsure how to do 0.9.3.1 for the 2.x branch and 0.9.3 (the latest released) for the 3.x branch. The .1 bug fix apparently just fixes the opensql.__version__ value, but that seems important. Maybe a local patch is the way to go?

[robsonpeixoto@…]

I'm unsure too.

If you add the version variable on if {${python.version} >= 30} { will work? Like

if {${python.version} >= 30} {
    version  0.9.3
} else {
    version  0.9.3.1
}

[stevecheckoway (Stephen Checkoway)]

Replying to robsonpeixoto@…:

I'm unsure too.

If you add the version variable on if {${python.version} >= 30} { will work? Like

if {${python.version} >= 30} {
    version  0.9.3
} else {
    version  0.9.3.1
}

Sorry for the slow response. I guess this works:

py-oursql @0.9.3.1 (python, devel, databases)
py26-oursql @0.9.3.1 (python, devel, databases)
py27-oursql @0.9.3.1 (python, devel, databases)
py31-oursql @0.9.3 (python, devel, databases)
py32-oursql @0.9.3 (python, devel, databases)
py33-oursql @0.9.3 (python, devel, databases)

It seems a little odd to have different versions.

It takes a little more effort to get this to work with Python 3.3. Namely, the oursqlx/oursql.c needs to be regenerated using Cython. I've got a new Portfile and the appropriate patch ready to go once #39510 lands.

Should I attach the patches to this ticket, to #39510, or create a new ticket? Should the patches for the new version be based on what's currently there or on #39510?

Edit: I attached updated patches to #39510 which go this route and make a few other changes.

[stevecheckoway (Stephen Checkoway)]

Cc Me!

[petrrr]

The update was implemented, but livecheck fails.