pficommon: add database variants

[ryandesign (Ryan Carsten Schmidt)]

pficommon currently has these variants:

pficommon has the variants:
   fcgi: Enable FastCGI module
   magickpp: Enable Magick++ of ImageMagick module
[+]mprpc: Enable MessagePack RPC module
   mysql: Obsolete compatibility variant
     * requires mysql5
   mysql5: Enable MySQL 5
   postgresql: Obsolete compatibility variant
     * requires postgresql91
   postgresql84: Enable PostgreSQL 8.4
     * conflicts with postgresql90 postgresql91
   postgresql90: Enable PostgreSQL 9.0
     * conflicts with postgresql84 postgresql91
   postgresql91: Enable PostgreSQL 9.1
     * conflicts with postgresql84 postgresql90
   universal: Build for multiple architectures

Could you please add variants for postgresql92 (conflicts with other postgresql variants) and mysql51, mysql55, mariadb and percona (conflict with mysql5 variant)?

The old "mysql" and "postgresql" variants can be removed; they've been "obsolete compatibility variants" for 18 months.

[humem (humem)]

Thanks for your proposal. I am impressed by variations of MySQL. Committed in r106180.

[ryandesign (Ryan Carsten Schmidt)]

I don't think that's enough. The new variants don't set the pg_version and my_version variables which get reinplaced into src/database/wscript. And simply having a variable my_version with a number isn't sufficient to express the path for mariadb or percona. Also, as I look at the wscript patch in the files directory, it contains hardcoded paths, including a hardcoded prefix, which need to be changed to placeholder strings that get reinplaced.

[humem (humem)]

Replying to ryandesign@…:

I don't think that's enough. The new variants don't set the pg_version and my_version variables which get reinplaced into src/database/wscript. And simply having a variable my_version with a number isn't sufficient to express the path for mariadb or percona. Also, as I look at the wscript patch in the files directory, it contains hardcoded paths, including a hardcoded prefix, which need to be changed to placeholder strings that get reinplaced.

Committed in r107038. Thanks.