Opened 11 years ago
Closed 11 years ago
#40295 closed enhancement (fixed)
librep @0.92.3_0: Remove compiler variants
| Reported by: | crossd@… | Owned by: | lloyd@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | librep |
Description
Please find attached a Portfile diff to add gcc48 and gcc49 variants to librep. I did this to bring librep inline with other ports, which seem to be defaulting to gcc48 and providing variants for gcc49.
Attachments (1)
Change History (8)
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 follow-up: 3 Changed 11 years ago by crossd@…
Hmm; I did that in #37953, but have only a vague recollection as to why...I think it had to do with failing to build using the default compiler. But then I patched whatever was failing.
Perhaps the thing to do is remove the gcc variants, instead of adding more?
comment:3 Changed 11 years ago by larryv (Lawrence Velázquez)
If there is no reason to have the variants, they should be removed.
comment:4 Changed 11 years ago by crossd@…
Sorry for the delay. Here is a Portfile update that simply removes the gcc variants. It seems I cannot edit the ticket description or like, so I'm afraid I can't update those bits.... Or perhaps I should open a new ticket? Whatever you folks think best.
Changed 11 years ago by crossd@…
| Attachment: | Portfile.librep.diff added |
|---|
comment:5 follow-up: 6 Changed 11 years ago by larryv (Lawrence Velázquez)
| Cc: | lloyd@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to lloyd@… |
| Summary: | libprep @0.92.3_0: Add gcc48 and gcc49 variants. → librep @0.92.3_0: Remove compiler variants |
comment:6 Changed 11 years ago by crossd@…
Replying to larryv@…:
Friendly ping.... I believe this has fallen outside of the maintainer window. Thanks!
comment:7 Changed 11 years ago by larryv (Lawrence Velázquez)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Maintainer timeout, r111021.
Hmm, why does librep offer any gcc variants at all? Most ports do not need them. They were added through #37953 but there was no explanation given why they were added.