#41229 closed defect (fixed)
easytag @2.1.7 Building fails on Mavericks
Reported by: | jochen@… | Owned by: | rmstonecipher@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.2.1 |
Keywords: | mavericks | Cc: | MaurizioLoreti, florian@…, dliessi (Davide Liessi), tehcog (tehcog) |
Port: | easytag |
Description
Building of easytag fails on Mavericks. All needed dependencies were properly installed.
port install easytag ---> Computing dependencies for easytag ---> Fetching archive for easytag ---> Attempting to fetch easytag-2.1.7_0.darwin_13.x86_64.tbz2 from http://lil.fr.packages.macports.org/easytag ---> Attempting to fetch easytag-2.1.7_0.darwin_13.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/easytag ---> Attempting to fetch easytag-2.1.7_0.darwin_13.x86_64.tbz2 from http://packages.macports.org/easytag ---> Fetching distfiles for easytag ---> Verifying checksums for easytag ---> Extracting easytag ---> Configuring easytag ---> Building easytag Error: org.macports.build for port easytag returned: command execution failed Please see the log file for port easytag for details: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_easytag/easytag/main.log To report a bug, follow the instructions in the guide: http://guide.macports.org/#project.tickets Error: Processing of port easytag failed
Find main.log attached.
Attachments (2)
Change History (15)
Changed 11 years ago by jochen@…
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | changed from macports-tickets@… to rmstonecipher@… |
---|---|
Port: | easytag added |
comment:2 Changed 11 years ago by david.e.pi.3.14@…
comment:3 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)
Keywords: | mavericks added |
---|
comment:4 Changed 11 years ago by MaurizioLoreti
A sort of "me too"... Today, MacPorts mp4v2 has been upgraded to @2.0.0_0 (sudo port upgrade outdated); easytag does not build. OS Mavericks.
---> Scanning binaries for linking errors: 100.0% ---> Found 1 broken file(s), matching files to ports ---> Found 1 broken port(s), determining rebuild order ---> Rebuilding in order easytag @2.1.7 ---> Computing dependencies for easytag ---> Fetching distfiles for easytag ---> Verifying checksums for easytag ---> Extracting easytag ---> Configuring easytag ---> Building easytag ... $ less /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_audio_easytag/easytag/main.log ... :info:build mp4_tag.c:438:21: error: too few arguments to function call, expecte d 2, have 1 :info:build MP4Close(mp4file); :info:build ~~~~~~~~ ^ :info:build /opt/local/include/mp4v2/file.h:55:1: note: 'MP4Close' declared here :info:build MP4V2_EXPORT :info:build ^ :info:build /opt/local/include/mp4v2/platform.h:38:25: note: expanded from macro 'MP4V2_EXPORT' :info:build # define MP4V2_EXPORT __attribute__((visibility("default"))) :info:build ^ :info:build 22 warnings and 4 errors generated. :info:build make[3]: *** [mp4_tag.o] Error 1
Changed 11 years ago by promac@…
Attachment: | easytag-2.1.7-mp4v2-build.patch added |
---|
Patch for using mp4v2 2.0 with easy tag 2.1.7
comment:7 follow-up: 8 Changed 11 years ago by promac@…
The attached patch fix all the compilation issues, and produces a working version of easytag 2.1.7 for macports on Mavericks.
comment:8 Changed 11 years ago by MaurizioLoreti
Replying to promac@…:
The attached patch fix all the compilation issues, and produces a working version of easytag 2.1.7 for macports on Mavericks.
Should we expect a new MacPorts package in a short time, or are we supposed to patch the source ourselves? Sorry, I didn't get this point.
comment:10 Changed 11 years ago by dliessi (Davide Liessi)
Not only on Mavericks.
Here are the latest lines of the main.log of sudo port install easytag
on Snow Leopard:
:info:build /usr/bin/gcc-4.2 -DHAVE_CONFIG_H -I. -I.. -DLOCALEDIR=\"/opt/local/share/locale\" -DPACKAGE_DATA_DIR=\"/opt/local/share/easytag\" -I/opt/local/include -pipe -Os -arch x86_64 -Wall -D_REENTRANT -I/opt/local/include/gtk-2.0 -I/opt/local/lib/gtk-2.0/include -I/opt/local/include/pango-1.0 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include -I/opt/local/include/cairo -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include/libpng15 -I/opt/local/include -I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/libpng15 -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/include/pango-1.0 -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/freetype2 -MT mp4_header.o -MD -MP -MF .deps/mp4_header.Tpo -c -o mp4_header.o mp4_header.c :info:build mp4_header.c: In function ‘Mp4_Header_Read_File_Info’: :info:build mp4_header.c:207: error: too many arguments to function ‘MP4Read’ :info:build mp4_header.c:221: error: too few arguments to function ‘MP4Close’ :info:build mp4_header.c:246: error: too few arguments to function ‘MP4Close’ :info:build make[3]: *** [mp4_header.o] Error 1 :info:build make[3]: *** Waiting for unfinished jobs.... :info:build mv -f .deps/misc.Tpo .deps/misc.Po :info:build make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_audio_easytag/easytag/work/easytag-2.1.7/src' :info:build make[2]: *** [all-recursive] Error 1 :info:build make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_audio_easytag/easytag/work/easytag-2.1.7/src' :info:build make[1]: *** [all-recursive] Error 1 :info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_audio_easytag/easytag/work/easytag-2.1.7' :info:build make: *** [all] Error 2 :info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_audio_easytag/easytag/work/easytag-2.1.7' :info:build Command failed: cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_audio_easytag/easytag/work/easytag-2.1.7" && /usr/bin/make -j2 -w all :info:build Exit code: 2 :error:build org.macports.build for port easytag returned: command execution failed :debug:build Error code: CHILDSTATUS 42978 2 :debug:build Backtrace: command execution failed while executing "system -nice 0 $fullcmdstring" ("eval" body line 1) invoked from within "eval system $notty $nice \$fullcmdstring" invoked from within "command_exec build" (procedure "portbuild::build_main" line 8) invoked from within "portbuild::build_main org.macports.build" ("eval" body line 1) invoked from within "eval $procedure $targetname" :info:build Warning: targets not executed for easytag: org.macports.activate org.macports.build org.macports.destroot org.macports.install :notice:build Please see the log file for port easytag for details: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_audio_easytag/easytag/main.log
I tested the patch file easytag-2.1.7-mp4v2-build.patch provided by promac. I confirm that the patched easytag compiles without errors and that it appears to run as expected, although I didn't test it thoroughly.
@promac: I had to manually edit the patch file to fix the file names. Please next time create source code patch files according to http://guide.macports.org/#development.patches.source.
comment:12 Changed 11 years ago by dbevans (David B. Evans)
Resolution: | → fixed |
---|---|
Status: | new → closed |
easytag updated to version 2.1.8 in r114974. Builds successfully on all buildbots including Mavericks.
comment:13 Changed 11 years ago by promac@…
Unfortunately, 2.1.8 has only a partial support to m4a, and the pictures are not accessible. That is why I am still using the patched 2.1.7 version ....
In my opinion, mac (apple store) means m4a, and without a full support, easytag on MacPorts is pointless...
This post in from an Ubuntu list, and makes me fear that a clean solution is far away:
http://comments.gmane.org/gmane.comp.audio.easytag.general/971
I had the same problem on Fedora 20, which forced me to install mp4v2 2.0 myself, dump version 2.1.8, and recompile 2.1.7.
Easytag depends on mp4v2-1.9 which does not build on Mavericks: #40813. mp4v2-2.0 builds on Mavericks (see the patch attached in #40813), but the current version of easytag in macports does not build against mp4v2... However I managed to compile easytag without mp4 support...