#42151 closed update (fixed)
stimfit @0.13.8: update 0.13.9
| Reported by: | neurodroid (Christoph Schmidt-Hieber) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | mojca (Mojca Miklavec) |
| Port: | stimfit |
Description
Adds biosig support; pending ticket #42147 Also fixes deprecated Google code download site. Portfile patch attached. I'm the maintainer, but I don't have commit rights.
Attachments (1)
Change History (9)
Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)
| Attachment: | Portfile-stimfit.patch added |
|---|
comment:1 Changed 11 years ago by mojca (Mojca Miklavec)
Please change
--- /Users/cs/macports/dports/science/stimfit/Portfile 2014-01-10 09:54:58.000000000 +0000 +++ ./science/stimfit/Portfile 2014-01-16 11:57:53.000000000 +0000
into something like
--- Portfile 2014-01-10 09:54:58.000000000 +0000 +++ Portfile 2014-01-16 11:57:53.000000000 +0000
next time when you submit patches. Otherwise it has to be done by the one trying to apply the patch.
comment:2 follow-up: 5 Changed 11 years ago by mojca (Mojca Miklavec)
Regarding your comment
will be required when wxpython gets available for Python 3.x
You can try out py-wxpython-3.0-phoenix from my personal branch (users/mojca/ports)
comment:3 Changed 11 years ago by mojca (Mojca Miklavec)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed in r116017. But a rebuild should probably be forced on 10.6 once you find a fix for biosig.
comment:4 Changed 11 years ago by mojca (Mojca Miklavec)
I forgot to say: I explicitly disabled biosig with --without-biosig. In case that user has biosig installed at the time building, installs stimfit and then removes biosig, then stimfit would remain broken.
comment:5 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)
Replying to mojca@…:
Regarding your comment
will be required when wxpython gets available for Python 3.x
You can try out
py-wxpython-3.0-phoenixfrom my personal branch (users/mojca/ports)
Unfortunately the Phoenix API doesn't support embedding a shell yet. I've raised this point on the wxPython-devel mailing list but haven't received any reply.
comment:6 follow-up: 7 Changed 11 years ago by mojca (Mojca Miklavec)
The issue will be forgotten if you leave it just on the mailing list and if there was no response right away.
I would suggest you to open a ticket in the tracker. That way at least someone might be reminded about the problem some time in future.
Other than that, given that you have a patch and in case that it would help you with further development, I could try to make a proper port (put it to trunk) and apply your patch. Then you can keep porting your project to Python 3.
comment:7 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)
Replying to mojca@…:
The issue will be forgotten if you leave it just on the mailing list and if there was no response right away.
I would suggest you to open a ticket in the tracker. That way at least someone might be reminded about the problem some time in future.
Will do.
Other than that, given that you have a patch and in case that it would help you with further development, I could try to make a proper port (put it to trunk) and apply your patch. Then you can keep porting your project to Python 3.
The patch is incomplete unfortunately. Some API functions that were present in "classic" wxPython are still missing in Phoenix. I'm currently trying to build Phoenix from Robin's github repository so that I can update the patch, but getting stuck at python build.py etg.
comment:8 Changed 11 years ago by mojca (Mojca Miklavec)
I didn't test etg. But the normal build succeeded. In case it helps you in any way to have the latest version from github automatically built on the buildbot on regular basis, we can also discuss that option (in a separate ticket).
stimfit Portfile patch