New port: zmap

[davidcadrian@…]

zmap 1.2.0 is released for OS X, Linux, BSD.

[davidcadrian@…]

zmap portfile

[mf2k (Frank Schima)]

The Milestone field is for Macports team members' use only, please do not set it.

[mf2k (Frank Schima)]

Cc reporter of request for this port in #41986.

[mf2k (Frank Schima)]

Some comments:

• This port should use the github portgroup to simplify the Portfile. See the ext4fuse port, among many others, for an example.
• Use depends_build-append and depends_lib-append when using portgroups to not overwrite dependencies brought in by the portgroups. For example, the cmake build dependency automatically comes with the cmake portgroup.
• Who is gmail.com:pat.pannuto and did he agree to maintain this port?
• Is there a reason to not always build in support for JSON and redis?

[artkiver (グレェ)]

Portfile for ZMap 3.0.0 RC2 with included improvements per the ticket.

[artkiver (グレェ)]

I submitted a PR here: ​https://github.com/macports/macports-ports/pull/18685

Alas, it appears as if one of the CI/build bot checks failed!

So, further work is apparently going to be required.

From what I can glean from the CI/build bot logs:

 --->  Attempting to fetch zmap-3.0.0-RC2.tar.gz from https://github.com/zmap/zmap
    0   153    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  DEBUG: Fetching distfile failed: The requested URL returned error: 404

[artkiver (グレェ)]

Tweaked the Portfile a little bit more which at least got rid of the 404 error mentioned above, but the CI build bots still weren't happy.

Closed PR ​https://github.com/macports/macports-ports/pull/18685 for now, but additional insights welcome!

I'll also attach the most recent Portfile I tried submitting (for beta1 rather than RC2 since when I ran

port -v livecheck

against RC2 it indicated that beta1 was more recent, so may as well submit a Portfile for the most recent version if submitting a new Portfile?

[artkiver (グレェ)]

Tried re-submitting as: ​https://github.com/macports/macports-ports/pull/18686

Excerpt from where the CI build bots failed: ​https://github.com/macports/macports-ports/actions/runs/4976009075/jobs/8903694293?pr=18686

  DEBUG: system:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1" && /opt/local/bin/cmake -DCMAKE_INSTALL_PREFIX='/opt/local' -DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON -DCMAKE_C_COMPILER="$CC" -DCMAKE_COLOR_MAKEFILE=ON -DCMAKE_CXX_COMPILER="$CXX" -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib -DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_MAKE_PROGRAM=/usr/bin/make -DCMAKE_MODULE_PATH=/opt/local/share/cmake/Modules -DCMAKE_SYSTEM_PREFIX_PATH="/opt/local;/opt/local;/usr" -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -Wno-dev -DCMAKE_C_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_OSX_ARCHITECTURES="x86_64" -DCMAKE_OSX_DEPLOYMENT_TARGET="13.0" -DCMAKE_OSX_SYSROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk" /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1 
  sh: /opt/local/bin/cmake: No such file or directory
  Command failed:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1" && /opt/local/bin/cmake -DCMAKE_INSTALL_PREFIX='/opt/local' -DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON -DCMAKE_C_COMPILER="$CC" -DCMAKE_COLOR_MAKEFILE=ON -DCMAKE_CXX_COMPILER="$CXX" -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib -DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_MAKE_PROGRAM=/usr/bin/make -DCMAKE_MODULE_PATH=/opt/local/share/cmake/Modules -DCMAKE_SYSTEM_PREFIX_PATH="/opt/local;/opt/local;/usr" -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -Wno-dev -DCMAKE_C_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_OSX_ARCHITECTURES="x86_64" -DCMAKE_OSX_DEPLOYMENT_TARGET="13.0" -DCMAKE_OSX_SYSROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk" /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1 
  Exit code: 127
  Error: Failed to configure zmap: configure failure: command execution failed
  DEBUG: Error code: NONE
  DEBUG: Backtrace: configure failure: command execution failed
      while executing
  "$procedure $targetname"
  Error: See /opt/local/var/macports/logs/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/main.log for details.
  Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
  Error: Processing of port zmap failed
  Build of 'zmap' failed.
  /Users/runner/work/macports-ports/macports-ports/mpbb/mpbb: error: `install-port' failed to run successfully
  /Users/runner/work/_temp/949985bf-d9bb-4c4a-91ff-90d7fea87d2c.sh: line 6: 10984 Terminated: 15          tail -f "$workdir/logs/dependencies-progress.txt" 2> /dev/null
Error: Failed to install zmap
Error: Process completed with exit code 1.

So it looks as if my tweaks to get rid of the depends_build cmake (since it was implied via PortGroup I thought) were incorrect.

Let me see if I can tweak it again.

[artkiver (グレェ)]

Another PR submitted and indeed, it seems not happy having json-c; so I guess breaking that out as a variant was perhaps ill advised?

For reference, I am including my (mostly broken) initial attempt at a Portfile which was a bit different.

I'm going to tweak things a bit further and see if I can get the CI build bots happy.

[artkiver (グレェ)]

my work in progress Portfile for ZMap before I noticed this ticket existed.

[artkiver (グレェ)]

OK, another PR attempt submitted: ​https://github.com/macports/macports-ports/pull/18688

The CI/build bots are still failing with a "cannot find libjson" despite my tweaks.

Excerpt from the error log:

  DEBUG: system:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1" && /opt/local/bin/cmake -DCMAKE_INSTALL_PREFIX='/opt/local' -DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON -DCMAKE_C_COMPILER="$CC" -DCMAKE_COLOR_MAKEFILE=ON -DCMAKE_CXX_COMPILER="$CXX" -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib -DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_MAKE_PROGRAM=/usr/bin/make -DCMAKE_MODULE_PATH=/opt/local/share/cmake/Modules -DCMAKE_SYSTEM_PREFIX_PATH="/opt/local;/opt/local;/usr" -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -Wno-dev -DCMAKE_C_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_OSX_ARCHITECTURES="x86_64" -DCMAKE_OSX_DEPLOYMENT_TARGET="13.0" -DCMAKE_OSX_SYSROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk" /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1 
  Executing:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1" && /opt/local/bin/cmake -DCMAKE_INSTALL_PREFIX='/opt/local' -DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON -DCMAKE_C_COMPILER="$CC" -DCMAKE_COLOR_MAKEFILE=ON -DCMAKE_CXX_COMPILER="$CXX" -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib -DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_MAKE_PROGRAM=/usr/bin/make -DCMAKE_MODULE_PATH=/opt/local/share/cmake/Modules -DCMAKE_SYSTEM_PREFIX_PATH="/opt/local;/opt/local;/usr" -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -Wno-dev -DCMAKE_C_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_OSX_ARCHITECTURES="x86_64" -DCMAKE_OSX_DEPLOYMENT_TARGET="13.0" -DCMAKE_OSX_SYSROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk" /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1 
  -- The C compiler identification is AppleClang 14.0.3.14030022
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: /usr/bin/clang - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
  CMake Error at CMakeLists.txt:74 (message):
    Did not find libjson
  
  
  -- Configuring incomplete, errors occurred!
  See also "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1/CMakeFiles/CMakeOutput.log".
  Command failed:  cd "/opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1" && /opt/local/bin/cmake -DCMAKE_INSTALL_PREFIX='/opt/local' -DCMAKE_BUILD_TYPE=Release -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON -DCMAKE_C_COMPILER="$CC" -DCMAKE_COLOR_MAKEFILE=ON -DCMAKE_CXX_COMPILER="$CXX" -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_INSTALL_NAME_DIR=/opt/local/lib -DCMAKE_INSTALL_RPATH=/opt/local/lib -DCMAKE_MAKE_PROGRAM=/usr/bin/make -DCMAKE_MODULE_PATH=/opt/local/share/cmake/Modules -DCMAKE_SYSTEM_PREFIX_PATH="/opt/local;/opt/local;/usr" -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -Wno-dev -DCMAKE_C_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" -DCMAKE_OSX_ARCHITECTURES="x86_64" -DCMAKE_OSX_DEPLOYMENT_TARGET="13.0" -DCMAKE_OSX_SYSROOT="/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk" /opt/local/var/macports/build/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/work/zmap-3.0.0-beta1 
  Exit code: 1
  Error: Failed to configure zmap: configure failure: command execution failed
  DEBUG: Error code: NONE
  DEBUG: Backtrace: configure failure: command execution failed
      while executing
  "$procedure $targetname"
  Error: See /opt/local/var/macports/logs/_Users_runner_work_macports-ports_macports-ports_ports_net_zmap/zmap/main.log for details.
  Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
  Error: Processing of port zmap failed
  Build of 'zmap' failed.
  /Users/runner/work/macports-ports/macports-ports/mpbb/mpbb: error: `install-port' failed to run successfully
  /Users/runner/work/_temp/7ac9ca8d-eaf9-463a-8452-aee1147e8b0e.sh: line 6: 12016 Terminated: 15          tail -f "$workdir/logs/dependencies-progress.txt" 2> /dev/null
Error: Failed to install zmap
Error: Process completed with exit code 1.

Additional insights welcome!

[artkiver (グレェ)]

After attempting, somewhat unsuccessfully, to create a Portfile for libjson (​https://github.com/vincenthz/libjson / ​https://projects.snarc.org/libjson/ though I was able to get it to build locally) I stumbled across this while searching for the same error message the CI/build bots were encountering:

​https://github.com/zmap/zmap/issues/109#issuecomment-31581216

Implying that pkgconfig is a build dependency.

So, tweaking the Portfile again and going to submit another PR and see if that makes the CI/build bots happy (certainly I think I already had pkgconfig installed locally).

Mostrecent PR submitted here: ​https://github.com/macports/macports-ports/pull/18689

CI/build bot checks passed! So, that was indeed the rub, an unmentioned dependency (which I had installed locally, so I didn't see that it was missing).

[artkiver (グレェ)]

In 719954eca851892b54cf76424680e690c6f2449f/macports-ports (master):

zmap: submission new Portfile ZMap version 3.0.0 beta1 (​https://github.com/macports/macports-ports/pull/18689)

• closes #42895
• closes #41986