Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#43328 closed defect (fixed)

librsvg dependent on gtk3?

Reported by: jshpettus@… Owned by: pixilla (Bradley Giesbrecht)
Priority: Normal Milestone:
Component: ports Version: 2.2.1
Keywords: haspatch Cc: dbevans (David B. Evans), cooljeanius (Eric Gallager), neverpanic (Clemens Lang)
Port: librsvg

Description

Why does the librsvg have a dependency on gtk3? Personally all I need it for is gtk2, and it certainly doesn't need gtk3 to compile for itself. Can this dependency be removed?

For me this is an issue as currently gtk3 isn't compiling with OS10.6

Attachments (1)

patch-librsvg-2.40.2+viewer.diff (4.1 KB) - added by dbevans (David B. Evans) 11 years ago.
Proposed patch to upgrade to version 2.40.2 with +viewer default variant

Download all attachments as: .zip

Change History (15)

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Cc: pixilla@… openmaintainer@… removed
Owner: changed from macports-tickets@… to pixilla@…

Please do not Cc openmaintainer@… because it is not a valid email address.

comment:2 Changed 11 years ago by dbevans (David B. Evans)

Cc: devans@… added

librsvg requires gtk3 to build included utility rsvg-view-3.

comment:3 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:4 Changed 11 years ago by jshpettus@…

Thanks for responding I see, but rsvg-veiw is only useful for people using gtk3 anyway. Can we make a variant for people who only want to bother with gtk2 and not have to install gtk3 as well? It’s still a waste.

Sry about the openmaintainer, Ill remember next time.

comment:5 in reply to:  4 Changed 11 years ago by pixilla (Bradley Giesbrecht)

Cc: cal@… added

Replying to jshpettus@…:

Thanks for responding I see, but rsvg-veiw is only useful for people using gtk3 anyway. Can we make a variant for people who only want to bother with gtk2 and not have to install gtk3 as well?

In principle a default variant to enable rsvg-view sound reasonable.

Not knowing gtk{2,3} or librsvg well I am confused by the dependencies.

See #32949 where we dropped the dependency on gtk2, so librsvg can be made a dependency of gtk2.

Would creating subports for rsvg-view or rsvg-view-3 help?

comment:6 Changed 11 years ago by dbevans (David B. Evans)

The problem is that the package has no configure option to disable the build of rsvg-view-3 so it will build if gtk3 is present and not otherwise. Just removing the gtk3 dependency won't do it as many other related ports now require gtk3. There is no longer a gtk2 option for this utility. I would suggest patching Makefile.am to build without rsvg-view-3 by default and adding a variant to build it by disabling this patch if desired.

comment:7 Changed 11 years ago by jshpettus@…

@devens that sounds to me like a good solution. Though to me the gtk2 version should be the variant as this would be a modification of the code. It's really weird. In linix repos, where it's already built, I'm fairly certian gtk3 isn't automatically installed with librsvg. though I could be wrong.

comment:8 Changed 11 years ago by dbevans (David B. Evans)

In that case, to conform to current variant guidelines, the variant would enable the build of the viewer and be asserted by default. You would then have to build librsvg -viewer to get what you want. This makes sense since gtk3 is the current version of GTK+ and gtk2 is deprecated and its use is increasingly disappearing from ports.

comment:9 Changed 11 years ago by jshpettus@…

Really? What applications use gtk3? Even gimp still uses gtk2 for their macport.

comment:10 Changed 11 years ago by dbevans (David B. Evans)

gimp and inkscape are current exceptions but both are working on gtk3 versions (see ports gimp3-devel and inkscape-devel +gtk3). All current GNOME ports use gtk3 exclusively.

Changed 11 years ago by dbevans (David B. Evans)

Proposed patch to upgrade to version 2.40.2 with +viewer default variant

comment:11 Changed 11 years ago by dbevans (David B. Evans)

Patch attached that adds a new default variant +viewer as well as updating the port to version 2.40.2 (#43331).

Last edited 11 years ago by dbevans (David B. Evans) (previous) (diff)

comment:12 Changed 11 years ago by dbevans (David B. Evans)

Keywords: haspatch added

comment:13 Changed 11 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

Patch committed in r118848 after email discussion with maintainer. Also closes #43331.

Install librsvg -viewer to avoid a gtk3 dependency at the expense of the rsvg-view-3 utility.

comment:14 in reply to:  8 Changed 11 years ago by jshpettus@…

neat! thanks a lot!

Note: See TracTickets for help on using tickets.