Opened 11 years ago
Closed 11 years ago
#43329 closed defect (fixed)
qt4-mac fails to build when using macosx_deployment_target on 10.9
| Reported by: | springermac (Jonathan Springer) | Owned by: | michaelld (Michael Dickens) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.2.1 |
| Keywords: | haspatch | Cc: | |
| Port: | qt4-mac |
Description
qt4-mac fails to build when using macosx_deployment_target on 10.9 due to patches using the system version and not the macosx_deployment_target version.
Attachments (1)
Change History (4)
Changed 11 years ago by springermac (Jonathan Springer)
| Attachment: | Portfile-qt4-mac.diff added |
|---|
comment:1 Changed 11 years ago by mf2k (Frank Schima)
| Cc: | michaelld@… removed |
|---|---|
| Keywords: | haspatch added |
| Owner: | changed from macports-tickets@… to michaelld@… |
comment:2 Changed 11 years ago by michaelld (Michael Dickens)
comment:3 Changed 11 years ago by michaelld (Michael Dickens)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Done in r118978. That said, I don't think this change should make a difference in whether qt4-mac works with any OSX version (10.9 or 10.8 or whatever). The Portfile should have worked, and if it did not before then there's no reason it should now. That said, I agree with the intent of this ticket, which is to say that the use of MINOR / os.version / macosx_deployment_target was inconsistent; this usage has been corrected now. Thanks!
Note: See
TracTickets for help on using
tickets.
Good catch. Your patch wasn't entirely correct, but I understand the intent now after reviewing it a few times. I'll push a fix shortly.