Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#43661 closed enhancement (fixed)

google-glog 0.3.3_1 (devel) Request to add gflags variant.

Reported by: sanchom (Sancho McCann) Owned by: humem (humem)
Priority: Low Milestone:
Component: ports Version:
Keywords: haspatch Cc: carlesfernandez (Carles Fernandez)
Port: google-glog

Description

If gflags is installed, google-glog can link against it so that command line flags can be used to control glog's behaviour. (See http://google-glog.googlecode.com/svn/trunk/doc/glog.html)

This port currently does not do this. I think it would be a good variant to add.

Attachments (1)

Portfile-google-glog.diff (593 bytes) - added by sanchom (Sancho McCann) 11 years ago.
Added gflags variant to Portfile

Download all attachments as: .zip

Change History (8)

comment:1 Changed 11 years ago by carlesfernandez (Carles Fernandez)

I would be also interested on that. Maybe a +gflags variant?

comment:2 Changed 11 years ago by carlesfernandez (Carles Fernandez)

Cc: carles.fernandez@… added

Cc Me!

comment:3 Changed 11 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to hum@…
Version: 2.2.1

In the future, please Cc the port maintainers (port info --maintainers google-glog).

Changed 11 years ago by sanchom (Sancho McCann)

Attachment: Portfile-google-glog.diff added

Added gflags variant to Portfile

comment:4 Changed 11 years ago by sanchom (Sancho McCann)

Just added a patch that should add this variant/dependency.

comment:5 Changed 11 years ago by neverpanic (Clemens Lang)

Keywords: haspatch added

comment:6 Changed 11 years ago by humem (humem)

Resolution: fixed
Status: newclosed

Thanks for your comment and patch. Committed in r119936.

comment:7 Changed 11 years ago by carlesfernandez (Carles Fernandez)

Wow, that was fast! Just tested it and works fine. Thanks everyone.

Note: See TracTickets for help on using tickets.