FileZilla: upgrade to the nightly version to get proper support for wxWidgets 3.0

[mojca (Mojca Miklavec)]

FileZilla developer finally switched to wxWidgets 3.0. This finally makes the port "usable" again (after SDK for 10.6 has been dropped, so almost three years).

I'm attaching a patch to switch to the nightly version with compatibility for wxWidgets 3.0 (please note that the patches should also be removed, but I didn't include that in the diff). My suggestion is to switch to this nightly version (and possibly keep it updating for a while, but not necessarily) until the official version comes out (and then switch to the official release again), also with the goal to get more testing of the software, so that any remaining issues can be polished before the release if necessary.

The first issue is the following message when launching the software (but it might be acceptable or it would at least let more people complain upstream?):

../src/osx/combobox_osx.cpp(60): assert "!(style & wxCB_SORT)" failed
in Create(): wxCB_SORT not currently supported by wxOSX/Cocoa

Call stack:
[00] wxComboBox::Create(wxWindow*, int, wxString const&, wxPoint
const&, wxSize const&, wxArrayString const&, long, wxValidator const&,
wxString const&)
[01] wxComboBox::wxComboBox(wxWindow*, int, wxString const&, wxPoint
const&, wxSize const&, wxArrayString const&, long, wxValidator const&,
wxString const&)
[02] CComboBoxEx::CComboBoxEx(CViewHeader*)
[03] CViewHeader::CViewHeader(wxWindow*, wxString const&)
[04] CLocalViewHeader::CLocalViewHeader(wxWindow*, CState*)
[05] CContextControl::CreateContextControls(CState*)
[06] CContextControl::CreateTab()
[07] CMainFrame::CMainFrame()
[08] CFileZillaApp::OnInit()
[09] wxApp::CallOnInit()
[10] wxEntry(int&, wchar_t**)
[11] main
[12] start
[13] 0x00000002 Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.

To maintainer: I'm aware that you don't have commit rights, I can commit this or something else, but please let me know if you are OK with the patch or if you would like to see something else.

This would also close #42448.

[mojca (Mojca Miklavec)]

SiteManager also keeps throwing:

wrapengine.cpp(735): assert "size.x <= bestWidth" failed in WrapRecursive().

Call stack:
[00] CWrapEngine::WrapRecursive(wxWindow*, double, char const*, wxSize, wxSize) 
[01] CSiteManagerDialog::Create(wxWindow*, std::vector<CSiteManagerDialog::_connected_site, std::allocator<CSiteManagerDialog::_connected_site> >*, CServer const*) 
[02] CMainFrame::OpenSiteManager(CServer const*) 
[03] CMainFrame::OnMenuHandler(wxCommandEvent&) 
[04] wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) 
[05] wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) 
[06] wxEvtHandler::TryHereOnly(wxEvent&)     
[07] wxEvtHandler::TryBeforeAndHere(wxEvent&) 
[08] wxEvtHandler::ProcessEventLocally(wxEvent&) 
[09] wxEvtHandler::ProcessEvent(wxEvent&)    
[10] wxWindowBase::TryAfter(wxEvent&)        
[11] wxEvtHandler::ProcessEvent(wxEvent&)    
[12] wxEvtHandler::SafelyProcessEvent(wxEvent&) 
[13] wxWindowBase::HandleWindowEvent(wxEvent&) const 
[14] wxMenuBase::SendEvent(int, int)         
[15] wxMenu::HandleCommandProcess(wxMenuItem*, wxWindow*) 
[16] -[wxNSMenuItem clickedAction:]          
[17] -[NSObject performSelector:withObject:] 
[18] -[NSApplication sendAction:to:from:]    
[19] -[NSMenuItem _corePerformAction]        
[20] -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] 
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.

[mojca (Mojca Miklavec)]

There's just one minor problem with my previous patch: it downloads the file to FileZilla/FileZilla3-src.tar.bz2 without using any information. The file either has to be renamed or relocated, else it will become impossible to upgrade to the next nightly.

[mojca (Mojca Miklavec)]

No feedback from maintainer. I noticed that 3.8.1 is out, so I upgraded to that version in r120942 before switching to the nightly and I'll adapt the patch for the nightly.

[mojca (Mojca Miklavec)]

I opened two upstream tickets:

• ​http://trac.filezilla-project.org/ticket/9578
• ​http://trac.filezilla-project.org/ticket/9579

[mojca (Mojca Miklavec)]

Ouch, I'm sorry. The upgrade causes a failed build against wxGTK (Cocoa works fine). Another upstream ticket:

• ​http://trac.filezilla-project.org/ticket/9580

(If we switch to the nightly, this probably will go away because there would be no need to build against wxGTK.)

[mojca (Mojca Miklavec)]

"Parse error."

FileZilla went from non-existent support for 3.0 to

checking for wxWidgets version >= 3.0.1 (--unicode=yes --universal=no)... no (version 3.0.0 is not new enough)

all within a few days (while it could in principle keep supporting 2.8 without problems).

See #44031.

[mojca (Mojca Miklavec)]

The attachment builds the latest nightly version (2014-06-16). In theory it works, a couple of issues have been fixed, but file browsing is weird and seems a bit broken.

[mojca (Mojca Miklavec)]

Committed in r121090 and r121091.