#44196 closed enhancement (fixed)
py-markupsafe: drop py24, py25, py31, py32 subports; update to 0.23
| Reported by: | lpsinger (Leo Singer) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | petrrr, jmroot (Joshua Root), michel.sylvan@…, seanfarley (Sean Farley), dh@…, stromnov (Andrey Stromnov) |
| Port: | py-markupsafe, py-jinja2, py-sphinx, py-sphinx-contrib, py-bpython, py-mako, py-opencl |
Description
Markupsafe does not support Python 3.1 or 3.2. According to the latest README file, it requires Python 2.6, 2.7, or 3.3+.
Also, markupsafe 0.23 is available.
The attached patch drops the Python 3.1 and 3.2 subports, while also updating markupsafe to version 0.23.
Attachments (1)
Change History (16)
Changed 10 years ago by lpsinger (Leo Singer)
| Attachment: | Portfile.diff added |
|---|
comment:1 Changed 10 years ago by mf2k (Frank Schima)
| Keywords: | haspatch added |
|---|---|
| Type: | defect → enhancement |
| Version: | 2.3.1 |
comment:2 Changed 10 years ago by lpsinger (Leo Singer)
comment:4 Changed 10 years ago by petrrr
| Owner: | changed from perry@… to macports-tickets@… |
|---|
Perry dropped maintainership of this port!
comment:5 Changed 10 years ago by lpsinger (Leo Singer)
Is there an automatic way to trace out which ports recursively depend upon py31-markupsafe or py32-markupsafe? port rdependents only finds ports that are currently installed.
comment:6 Changed 10 years ago by petrrr
Might the following be an option?
petr% port echo depends:py31-markupsafe py31-jinja2 petr% port echo depends:py32-markupsafe py32-jinja2 py32-mako
comment:7 Changed 10 years ago by lpsinger (Leo Singer)
Thanks. Wrapped in a recursive bash script, that gives me:
- py32-jinja2 maintainer: jmr@…, openmaintainer@…
- py32-sphinx maintainer: jmr@…, michel.sylvan@…, openmaintainer@…
- py32-sphinx-contrib maintainer: sean@…, openmaintainer@…
- py32-bpython maintainer: aronnax@…, openmaintainer@…
- py32-mako maintainer: dh@…, stromnov@…
- py32-pyopencl maintainer: nomaintainer@…
- py31-jinja2 maintainer: jmr@…, openmaintainer@…
- py31-sphinx maintainer: jmr@…, michel.sylvan@…, openmaintainer@…
- py31-sphinx-contrib maintainer: sean@…, openmaintainer@…
- py31-bpython maintainer: aronnax@…, openmaintainer@…
comment:8 Changed 10 years ago by lpsinger (Leo Singer)
| Cc: | jmr@… michel.sylvan@… sean@… dh@… stromnov@… added |
|---|---|
| Port: | py-jinja2 py-sphinx py-sphinx-contrib py-bpython py-mako py-opencl added |
CCing all the maintainers of ports that depend directly or indirectly on py31-markupsafe or py32-markupsafe.
Because markupsafe has dropped support for Python 3.1 and 3.2, I would like to drop the py31- and py32- subports for these ports. Is this OK?
BTW, all of the ports except for py-mako are openmaintainer or nomaintainer.
comment:9 Changed 10 years ago by lpsinger (Leo Singer)
| Summary: | py-markupsafe: drop py31, py32 subports; update to 0.23 → py-markupsafe: drop py24, py25, py31, py32 subports; update to 0.23 |
|---|
Upon closer reading of the README file:
Markupsafe supports Python 2.6, 2.7 and Python 3.3 and higher.
So we need to drop the py24 and py25 subports as well. This adds the py-pylons and py-webhelpers ports, which are both nomaintainer.
comment:10 Changed 10 years ago by lpsinger (Leo Singer)
My dependency traversal was not quite right. Here is the full list of affected ports:
py24-jinja2 maintainers: jmr@macports.org, openmaintainer@macports.org py24-mako maintainers: dh@macports.org, stromnov@macports.org py24-webhelpers maintainers: nomaintainer@macports.org py25-jinja2 maintainers: jmr@macports.org, openmaintainer@macports.org py25-mako maintainers: dh@macports.org, stromnov@macports.org py25-pylons maintainers: nomaintainer@macports.org py25-webhelpers maintainers: nomaintainer@macports.org py31-jinja2 maintainers: jmr@macports.org, openmaintainer@macports.org py32-jinja2 maintainers: jmr@macports.org, openmaintainer@macports.org py32-mako maintainers: dh@macports.org, stromnov@macports.org py24-libnamebench maintainers: nomaintainer@macports.org py24-smisk maintainers: rasmus@macports.org py25-flask maintainers: ryandesign@macports.org, openmaintainer@macports.org py25-libnamebench maintainers: nomaintainer@macports.org py25-sphinx maintainers: jmr@macports.org, michel.sylvan@gmail.com, openmaintainer@macports.org py25-pylons maintainers: nomaintainer@macports.org py25-smisk maintainers: rasmus@macports.org py31-sphinx maintainers: jmr@macports.org, michel.sylvan@gmail.com, openmaintainer@macports.org py32-sphinx maintainers: jmr@macports.org, michel.sylvan@gmail.com, openmaintainer@macports.org py32-pyopencl maintainers: nomaintainer@macports.org py-libnamebench maintainers: nomaintainer@macports.org py-smisk maintainers: rasmus@macports.org py25-flask-auth maintainers: nomaintainer@macports.org py25-flask-babel maintainers: nomaintainer@macports.org py25-flask-frozen maintainers: nomaintainer@macports.org py25-flask-login maintainers: aronnax@macports.org, openmaintainer@macports.org py25-flask-mail maintainers: aronnax@macports.org, openmaintainer@macports.org py25-flask-mongoalchemy maintainers: nomaintainer@macports.org py25-flask-restful maintainers: cal@macports.org, openmaintainer@macports.org py25-flask-sqlalchemy maintainers: nomaintainer@macports.org py25-flask-uploads maintainers: nomaintainer@macports.org py25-flask-wtf maintainers: nomaintainer@macports.org py25-sphinx-contrib maintainers: sean@macports.org, openmaintainer@macports.org py25-roundup maintainers: nomaintainer@macports.org py25-visa maintainers: nomaintainer@macports.org py31-sphinx-contrib maintainers: sean@macports.org, openmaintainer@macports.org py31-bpython maintainers: aronnax@macports.org, openmaintainer@macports.org py32-sphinx-contrib maintainers: sean@macports.org, openmaintainer@macports.org py32-bpython maintainers: aronnax@macports.org, openmaintainer@macports.org
comment:12 follow-up: 13 Changed 10 years ago by lpsinger (Leo Singer)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in r124632.
comment:13 Changed 10 years ago by jmroot (Joshua Root)
Replying to aronnax@…:
Fixed in r124632.
That’s only the direct dependents of markupsafe. Now the ports that depend on the ports that were removed in this revision are broken.
% port lint depends:py.\*-bpython depends:py.\*-flask-auth depends:py.\*-flask-babel depends:py.\*-flask-frozen depends:py.\*-flask-login depends:py.\*-flask-mail depends:py.\*-flask-mongoalchemy depends:py.\*-flask-restful depends:py.\*-flask-sqlalchemy depends:py.\*-flask-uploads depends:py.\*-flask-wtf depends:py.\*-jinja2 depends:py.\*-libnamebench depends:py.\*-pylons depends:py.\*-pyopencl depends:py.\*-roundup depends:py.\*-sphinx depends:py.\*-sphinx-contrib depends:py.\*-visa depends:py.\*-webhelpers [lines with no errors removed…] ---> Verifying Portfile for py25-sphinx Error: Unknown dependency: py25-jinja2 ---> 1 errors and 0 warnings found. ---> Verifying Portfile for py31-sphinx Error: Unknown dependency: py31-jinja2 ---> 1 errors and 0 warnings found. ---> Verifying Portfile for py32-sphinx Error: Unknown dependency: py32-jinja2 ---> 1 errors and 0 warnings found.
And after those are fixed, their dependents need to be fixed, and so on until there are no more dependents.
% port echo depends:py.\*-sphinx py-sphinx py-sphinx-contrib py26-sfepy py26-sphinx-contrib py26-spyder py26-spyder-devel py27-sfepy py27-sphinx-contrib py27-spyder py27-spyder-devel py33-sphinx-contrib py33-spyder py33-spyder-devel py34-sphinx-contrib py34-spyder py34-spyder-devel vigra bedtools bob glom gnuradio gnuradio-devel gnuradio-legacy gnuradio-next offlineimap offlineimap-devel py26-bpython py26-flask-mail py26-mayavi py26-openslide py26-roundup py26-trep py26-visa py27-bpython py27-flask-mail py27-mayavi py27-openslide py27-roundup py27-trep py27-visa py33-bpython tortoisehg
comment:14 follow-up: 15 Changed 10 years ago by jmroot (Joshua Root)
My mistake, you did try to do the recursive dependents. But you did miss sphinx somehow.
comment:15 Changed 10 years ago by lpsinger (Leo Singer)
Replying to jmr@…:
My mistake, you did try to do the recursive dependents. But you did miss sphinx somehow.
You're right, I missed sphinx. But I don't see any ports that depend on py25-sphinx or py31-sphinx.
Just FYI, several other packages that have Python 3.1 and 3.2 subports depend on markupsafe, so if these variants are dropped from markupsafe the effect would have to cascade.