launch4j: update to 3.4 and tidy portfile

[steve+macports@…]

launch4j is now at version 3.4 upstream.

I'm attaching a proposed Portfile that includes these changes:

1. Tidy up
   1. Normalise whitespace - replace tabs with spaces.
   2. Use absolute instead of relative path for symlink to executable. Looking through my /opt/local/bin, this seems to be the convention in MacPorts.
   3. Reorganise modifications to extracted files and add comments. First delete the various groups of unwanted files, then move the documentation into place, then install the program files.
   4. Add license info.
2. Update to version 3.4
   1. Update version and distname, replace checksums with types advised in guide.
   2. Delete / move newly added files in distribution.
   3. Remove patchfile and instead use reinplace to set the absolute path to launch4j.jar in launch4j script. The upstream script looks for the jar in the same directory as the script, which won't work when the script is executed via a link. The patchfile (which no longer works against version 3.4) fixed this for the symlink, but broke the real script. An alternative is to use a wrapper script (that just execs the real script) instead of a symlink, as used by clang-3.x for example.

I'm new here, so I'd appreciate some guidance on whether to provide one big diff, or break my changes up into several patches and attach them here, or to split some of this off into a separate ticket. Cheers.

[steve+macports@…]

Note that the copies of ld and windres bundled with launch4j have changed between versions 3.0.2 and 3.4. They were previously ppc-only, and are now x86_64. To get launch4j 3.0.2 to work on x86, I replaced those files with symlinks to the ones provided by i386-mingw32-binutils. This workaround might also work for anyone wanting to use launch4j 3.4 on ppc.

[mf2k (Frank Schima)]

​Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. Please keep whitespace changes in a separate patch from functional changes.

[steve+macports@…]

OK thanks, will do.

[kurthindenburg (Kurt Hindenburg)]

Cc Me!

[kurthindenburg (Kurt Hindenburg)]

The whitespace diff committed r126184

The other patch still applies cleanly.

[amake (Aaron Madlon-Kay)]

This ticket is potentially obsoleted by ​https://github.com/macports/macports-ports/pull/4286

[Aaron Madlon-Kay <amake@…>]

In b29d8a11e93079a89d8d789369fcdef3a6fd75c2/macports-ports (master):

launch4j: update to 3.12

Fixes: #44197