Opened 10 years ago

Closed 10 years ago

#44311 closed update (fixed)

py-impressive: update to 0.10.5 and switch to hybrid `PIL`/`Pillow` dependency

Reported by: Ionic (Mihai Moldovan) Owned by: petrrr
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: py-impressive

Description

py-impressive has been updated to version 0.10.5 which includes changes to make it Pillow-compatible by upstream.

Also switch to the new hybrid PIL/Pillow dependency style as suggested in #44281.

Attachments (1)

py-impressive-update-0.10.5-pil-pillow-hybrid-dep.patch (1.3 KB) - added by Ionic (Mihai Moldovan) 10 years ago.
Update py-impressive to version 0.10.5 and change py*-pil dependency to new PIL/Pillow hybrid one.

Download all attachments as: .zip

Change History (14)

Changed 10 years ago by Ionic (Mihai Moldovan)

Update py-impressive to version 0.10.5 and change py*-pil dependency to new PIL/Pillow hybrid one.

comment:1 Changed 10 years ago by petrrr

Just a detail, the revision 0, is the default. So it is not to be specified.

comment:2 Changed 10 years ago by Ionic (Mihai Moldovan)

I know it is, but I personally like adding revision 0 anyway, because it makes revbumping easier should the revision need to be changed. (I.e., I won't have to write "revision" again after removing it.)

That's just a personal thing.

comment:3 Changed 10 years ago by petrrr

BTW: Are other python versions, other then 2.6, now supported?

comment:4 Changed 10 years ago by Ionic (Mihai Moldovan)

Yes, python 2.5 to 2.7 is supported. At least officially by the software author. I didn't update that though because I had no time to test if it's really working.

(py-impressive sounds awesome though)

comment:5 Changed 10 years ago by petrrr

There might be an issue with port:pdftk on some systems. But that's a different story.

comment:6 Changed 10 years ago by petrrr

Owner: changed from macports-tickets@… to petr@…
Status: newassigned

comment:7 Changed 10 years ago by petrrr

Thanks! Committed in r121929.

Last edited 10 years ago by petrrr (previous) (diff)

comment:8 Changed 10 years ago by Ionic (Mihai Moldovan)

Oh, I remember why I didn't look into the 2.7 issue:

Quote from portfile:

[...]
    python.link_binaries no
    # this is bad, a py27-impressive would conflict with py26-impressive
    # make non-conflicting or change name to just 'impressive'
    destroot {
[...]

Does it work nowadays?

comment:9 in reply to:  7 Changed 10 years ago by Ionic (Mihai Moldovan)

Replying to petr@…:

Thanks! Committed in r121929.

Thanks for committing!

I added the py27 subport as well.

No, you actually didn't, but that's probably for the best (see my comment above.)

comment:10 Changed 10 years ago by petrrr

I already noticed and change the comment above and now the commit message as well.

Yes, I will look at py27 subport later and so leave the ticket open for the moment. It looks like this is actually an application not a module so probably should be renamed.

comment:11 in reply to:  10 Changed 10 years ago by Ionic (Mihai Moldovan)

Replying to petr@…:

Yes, I will look at py27 subport later and so leave the ticket open for the moment. It looks like this is actually an application not a module so probably should be renamed.

Is python/py-* reserved for modules only? I suspect there are lot of standalone applications in this category with that naming scheme.

comment:12 Changed 10 years ago by petrrr

Cc: petr@… removed

Cc Me!

comment:13 Changed 10 years ago by petrrr

Resolution: fixed
Status: assignedclosed

Renaming py-impressive (python package) to impressive (python app) is handled in #44538 and committed in r123616. Closing!

Note: See TracTickets for help on using tickets.