Opened 10 years ago

Closed 10 years ago

#44312 closed defect (fixed)

root5: bindings/pyroot/src/TPyDispatcher.cxx:243:31: error: use of undeclared identifier 'PyString_FromString'

Reported by: graziosi.angelo@… Owned by: mojca (Mojca Miklavec)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: cjones051073 (Chris Jones)
Port: root5

Description

This evening:

$ sudo port selfupdate
Password:
--->  Updating MacPorts base sources using rsync
MacPorts base version 2.3.1 installed,
MacPorts base version 2.3.1 downloaded.
--->  Updating the ports tree
--->  MacPorts base is already the latest version

The ports tree has been updated. To upgrade your installed ports, you should run
  port upgrade outdated

 sudo port outdated
The following installed ports are outdated:
root5                          5.34.18_0 < 5.34.19_0
texinfo                        5.2_0 < 5.2_1


$ sudo port upgrade outdated
--->  Computing dependencies for root5
--->  Fetching archive for root5
--->  Attempting to fetch root5-5.34.19_0+avahi+cocoa+fftw3+fitsio+gcc48+graphviz+gsl+http+ldap+minuit2+mysql55+odbc+opengl+postgresql92+pythia+python34+qt_mac+roofit+soversion+sqlite3+ssl+tmva+xml+xrootd.darwin_13.x86_64.tbz2 from http://nue.de.packages.macports.org/macports/packages/root5
--->  Attempting to fetch root5-5.34.19_0+avahi+cocoa+fftw3+fitsio+gcc48+graphviz+gsl+http+ldap+minuit2+mysql55+odbc+opengl+postgresql92+pythia+python34+qt_mac+roofit+soversion+sqlite3+ssl+tmva+xml+xrootd.darwin_13.x86_64.tbz2 from http://lil.fr.packages.macports.org/root5
--->  Attempting to fetch root5-5.34.19_0+avahi+cocoa+fftw3+fitsio+gcc48+graphviz+gsl+http+ldap+minuit2+mysql55+odbc+opengl+postgresql92+pythia+python34+qt_mac+roofit+soversion+sqlite3+ssl+tmva+xml+xrootd.darwin_13.x86_64.tbz2 from http://mse.uk.packages.macports.org/sites/packages.macports.org/root5
--->  Fetching distfiles for root5
--->  Attempting to fetch root_v5.34.19.source.tar.gz from http://fco.it.distfiles.macports.org/mirrors/macports-distfiles/root
--->  Attempting to fetch root_v5.34.19.source.tar.gz from http://nue.de.distfiles.macports.org/macports/distfiles/root
--->  Attempting to fetch root_v5.34.19.source.tar.gz from http://lil.fr.distfiles.macports.org/root
--->  Attempting to fetch root_v5.34.19.source.tar.gz from http://mse.uk.distfiles.macports.org/sites/distfiles.macports.org/root
--->  Attempting to fetch root_v5.34.19.source.tar.gz from http://root.cern.ch/download/
--->  Verifying checksums for root5
--->  Extracting root5
--->  Applying patches to root5
--->  Configuring root5
--->  Building root5
Error: org.macports.build for port root5 returned: command execution failed
Please see the log file for port root5 for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root5/root5/main.log
Error: Unable to upgrade port: 1
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets

Ciao, Angelo.

Attachments (1)

root-main.log.bz2 (50.0 KB) - added by graziosi.angelo@… 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by graziosi.angelo@…

Attachment: root-main.log.bz2 added

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: mojca@… removed
Owner: changed from macports-tickets@… to mojca@…
Port: root5 added; roor/root5 removed
Summary: Failure upgrading ROOT(5)root5: bindings/pyroot/src/TPyDispatcher.cxx:243:31: error: use of undeclared identifier 'PyString_FromString'

comment:2 Changed 10 years ago by mojca (Mojca Miklavec)

From https://docs.python.org/2/c-api/string.html:

These functions have been renamed to PyBytes_* in Python 3.x. Unless otherwise noted, the PyBytes functions available in 3.x are aliased to their PyString_* equivalents to help porting.

https://docs.python.org/3/c-api/bytes.html

comment:3 Changed 10 years ago by mojca (Mojca Miklavec)

And this has been fixed recently in version 6:

We need to ask the upstream developers if they plan to support Python3 in ROOT 5.

comment:4 Changed 10 years ago by cjones051073 (Chris Jones)

Thanks for the report. Until fixed upstream I suggest as a work around switching to one of the python 2.X variants, which stills works fine.

comment:5 Changed 10 years ago by mojca (Mojca Miklavec)

Upstream claims to have fixed the issue.

I'm not sure if it's just https://github.com/root-mirror/root/commit/fb258576e9f7971305df1a4bcf3dea8d76bcaadd or also something else.

I'm not (yet?) maintainer of ROOT5. Ryan probably got it wrong. I happily leave the testing to maintainers, but since no maintainer has commit rights anyway, I'll commit the patch once I get the confirmation that it's ok (probably no need for a revbump).

comment:6 Changed 10 years ago by mojca (Mojca Miklavec)

Resolution: fixed
Status: newclosed
Version: 2.3.1

Committed in r122677.

Note: See TracTickets for help on using tickets.