Opened 10 years ago

Closed 9 years ago

#45205 closed update (fixed)

dash @0.5.7: update to @0.5.8

Reported by: RJVB (René Bertin) Owned by: Mathias.Laurin+macports@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: dash

Description

With the recent ShellShock issue there has been a suggestion that it could be wise to replace /bin/sh with /bin/dash instead of even with the latest bash version.

This update to dash portfile brings the port to the latest release (and corrects the livecheck feature). Not to make it lose too much functionality I have it built --with-libedit, linking to the system libedit instead of the (obsolete) one in MacPorts. I did *not* test this (yet) against libedit.3.dylib .

It could be an interesting idea to extend this (and the bash) ports further with a helper script that replaces the system sh (bash) with the port's version. I thought about adding a variant that does this, but realised I'd better leave that to people with a better knowledge of what features MacPorts provide that would detect when an Apple update had installed a new sh (bash) version.

Attachments (3)

dash-diff.diff (1.1 KB) - added by RJVB (René Bertin) 10 years ago.
use-system-libedit.patch (983 bytes) - added by RJVB (René Bertin) 10 years ago.
Portfile-dash.diff (1.2 KB) - added by Mathias.Laurin+macports.org@… 10 years ago.
Update to 0.5.8

Download all attachments as: .zip

Change History (14)

Changed 10 years ago by RJVB (René Bertin)

Attachment: dash-diff.diff added

Changed 10 years ago by RJVB (René Bertin)

Attachment: use-system-libedit.patch added

comment:1 in reply to:  description Changed 10 years ago by RJVB (René Bertin)

Replying to rjvbertin@…:

This update to dash portfile brings the port to the latest release (and corrects the livecheck feature). Not to make it lose too much functionality I have it built --with-libedit, linking to the system libedit instead of the (obsolete) one in MacPorts. I did *not* test this (yet) against libedit.3.dylib .

NB: I have made no attempt to ensure that the system headerfiles are picked up; would that be necessary? I tested with a deactivated libedit port, and things built fine.

PS: is there a reason port:libedit is so far behind? I could build Apple's libedit-39 from OS X 10.9.4 just fine under OS X 10.6 ...

Last edited 10 years ago by RJVB (René Bertin) (previous) (diff)

comment:2 Changed 10 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to Mathias.Laurin+macports@…
Priority: HighNormal

Please leave the Priority field to Macports committers and Cc the port maintainers (port info --maintainers dash).

comment:3 Changed 10 years ago by RJVB (René Bertin)

I stopped doing the latter since I noticed that someone always changed the Cc entry or list I'd entered - and I don't particularly like looking up and entering information for nothing...

comment:4 Changed 10 years ago by mf2k (Frank Schima)

Well we don't like looking it up and updating tickets either.

comment:5 in reply to:  description Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to rjvbertin@…:

This update to dash portfile brings the port to the latest release (and corrects the livecheck feature). Not to make it lose too much functionality I have it built --with-libedit, linking to the system libedit instead of the (obsolete) one in MacPorts. I did *not* test this (yet) against libedit.3.dylib .

We prefer to use our own libraries. If the libedit port is outdated, we should bring it up to date.

It could be an interesting idea to extend this (and the bash) ports further with a helper script that replaces the system sh (bash) with the port's version. I thought about adding a variant that does this, but realised I'd better leave that to people with a better knowledge of what features MacPorts provide that would detect when an Apple update had installed a new sh (bash) version.

Sorry, we will never implement this. We do not accommodate users who wish to screw up their OS X installations by replacing Apple-provided components. Anyone who wants to replace their /bin/sh with some other shell can easily whip up their own source build and do the deed on their own.

comment:6 in reply to:  3 Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to rjvbertin@…:

I stopped doing the latter since I noticed that someone always changed the Cc entry or list I'd entered - and I don't particularly like looking up and entering information for nothing...

If the maintainers are correctly Cc’d, we usually just move their email address from the Cc list to the Owner field.

Changed 10 years ago by Mathias.Laurin+macports.org@…

Attachment: Portfile-dash.diff added

Update to 0.5.8

comment:7 Changed 10 years ago by Mathias.Laurin+macports.org@…

Thank you for the update.

Compilation of dash 0.5.8 (without libedit, see Portfile-dash.diff) and small tests did work without any glitches on my system.

libedit is optional anyway. Do you (@rjvbertin) really use dash interactively?

comment:8 Changed 10 years ago by RJVB (René Bertin)

Yes, libedit is optional. As I said I preferred to link to the system one because the only reason I can think of including it is when someone wants to replace /bin/sh with dash, and in that case it'd better be as independent from the rest of MacPorts as possible.

No, I don't use dash interactively willingly/knowlingly, except when I enter sh to experiment with shell programming constructs when writing a script.

comment:9 Changed 10 years ago by petrrr

Summary: dash updatedash @0.5.7: update to @0.5.8

comment:10 Changed 9 years ago by larryv (Lawrence Velázquez)

I’ll take care of this soon.

comment:11 Changed 9 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: newclosed

r136916:136918

Mathias didn’t seem keen on the libedit dependency, so I didn’t add it. Please start a new ticket or mailing list thread if you want to broach the subject again.

Note: See TracTickets for help on using tickets.