xfce4-settings @4.6.5 fails to build due to a change in libnotify

[wyatt8750@…]

LibNotify's notify_notification_new() now takes fewer arguments than it used to, and the version of xfce4-settings in macports is still using the old argument count. Line 420 in accessibility is to blame, and it can be made to compile by doing something like this:

--- old/xfce4-settings-4.6.5/xfce4-settings-helper/accessibility.c	2015-04-25 19:55:26.000000000 -0400
+++ xfce4-settings-4.6.5/xfce4-settings-helper/accessibility.c	2015-04-25 19:55:36.000000000 -0400
@@ -417,7 +417,7 @@
     if (helper->notification == NULL)
     {
         /* create a new notification */
-        helper->notification = notify_notification_new (summary, body, "keyboard", NULL);
+        helper->notification = notify_notification_new (summary, body, "keyboard");
 
         /* close signal */
         g_signal_connect (G_OBJECT (helper->notification), "closed", G_CALLBACK (xfce_accessibility_helper_notification_closed), helper);

I don't know if my paths in that patch are correct, but this did seem to fix my issue. If it matters, I am running OS X 10.6.8 (snow leopard) with xcode 4.2's SDK. The patch is also attached, as is the original build log.

[wyatt8750@…]

Original main.log containing the build error

[wyatt8750@…]

a patch that should allow xfce4-settings to build with the change in libnotify. I have not tested to make sure that this does not break anything, I just know that it builds with this.

[ryandesign (Ryan Carsten Schmidt)]

Perhaps we should try updating the port to the current version (4.12) first.

[cooljeanius (Eric Gallager)]

Cc Me!

[wyatt8750@…]

Maybe updating would be a good move.

[afb@…]

Fixed, r144133.