Opened 10 years ago
Closed 9 years ago
#47661 closed defect (fixed)
gwenhywfar4 corrections
Reported by: | RJVB (René Bertin) | Owned by: | mkae (Marko Käning) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | drkp (Dan Ports) |
Port: | gwenhywfar4 |
Description
port:gwenhywfar4 depends on port:qt4-mac{,-devel} in the wrong way, and didn't catch an error in the buildsystem that presumes OS X has shared libraries with a .so extension. The attached patch corrects this.
Attachments (2)
Change History (6)
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 10 years ago by RJVB (René Bertin)
So for this port I actually followed your platform-independent way of adding platform-dependent code to the cmake files :) because I noticed a few other issues with the port as well. The cpp "GUI" is required, at least if you want to use the Qt4 gui (from kmymoney4).
Changed 10 years ago by RJVB (René Bertin)
Attachment: | gwenhywfar4.diff added |
---|
Changed 10 years ago by RJVB (René Bertin)
Attachment: | patch-shlib-extensions.diff added |
---|
comment:3 Changed 9 years ago by mkae (Marko Käning)
Cc: | mk@… removed |
---|---|
Owner: | changed from macports-tickets@… to mk@… |
comment:4 Changed 9 years ago by mkae (Marko Käning)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Committed in r138041.
Thanks, René!
Note: See
TracTickets for help on using
tickets.
Rather than
reinplace
gwenhywfar-config.cmake after destroot, you should probably write a normal patchfile for gwenhywfar-config.cmake.in, to be applied in aplatform darwin
block, or better yet, in a platform-independent way, for example by using cmake'sIF(APPLE)
syntax.