Opened 10 years ago

Closed 9 years ago

#47662 closed defect (fixed)

port:aqbanking5 correction

Reported by: RJVB (René Bertin) Owned by: mkae (Marko Käning)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: drkp (Dan Ports)
Port: aqbanking5

Description

port:aqbanking5 didn't catch an error in the buildsystem that presumes OS X has shared libraries with a .so extension. The attached patch corrects this.

Attachments (1)

aqbanking5.diff (728 bytes) - added by RJVB (René Bertin) 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by RJVB (René Bertin)

Attachment: aqbanking5.diff added

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Rather than reinplace aqbanking-config.cmake after destroot, you should probably write a normal patchfile for aqbanking-config.cmake.in, to be applied in a platform darwin block, or better yet, in a platform-independent way, for example by using cmake's IF(APPLE) syntax.

comment:2 Changed 10 years ago by RJVB (René Bertin)

yeah, well, since the end result is the same and I only installed this port (and gwenhywfar4) to hunt down an issue in yet another port I'm going to leave that to the port maintainer(s) ;)

What's platform-independent about an IF(APPLE) block ... you remind me of our minister of education who considers halal to be "non-confessional" :))

Last edited 10 years ago by RJVB (René Bertin) (previous) (diff)

comment:3 Changed 9 years ago by mkae (Marko Käning)

Cc: mk@… removed
Owner: changed from macports-tickets@… to mk@…

comment:4 Changed 9 years ago by mkae (Marko Käning)

Cc: rjvbertin@… added

comment:5 in reply to:  4 Changed 9 years ago by RJVB (René Bertin)

Replying to mk@…:

Why? I reported the ticket; what are you expecting from me?

comment:6 Changed 9 years ago by mkae (Marko Käning)

Cc: rjvbertin@… removed

Sorry, that happened by mistake. :)

comment:7 Changed 9 years ago by mkae (Marko Käning)

Resolution: fixed
Status: newclosed

Committed in r138042.

Thanks, René!

Note: See TracTickets for help on using tickets.