notmuch: Add support for installing man pages

[cceleri@…]

Hello,

The attached patch adds the correct support for building the Notmuch man pages. A simple patch file is addes to files/ in order to resolve problems where the python executable is not found by the Notmuch configure script.

Best, Charles

[ryandesign (Ryan Carsten Schmidt)]

There is a stray backslash at the end of your depends_lib.

Are you saying that prior to this patch, manpages might not be installed, but after this patch, they will be? If so, the port's revision needs to be increased so that anyone who doesn't already have the manpages will get them.

[cceleri@…]

Yes, the man pages will not be installed if the following test fails in the configure script

if command -v sphinx-build > /dev/null && ${python} -m sphinx.writers.manpage > /dev/null 2>&1 ; then
  ...

where ${python} is set earlier by

for name in python python2 python3; do
    if command -v $name > /dev/null; then
        have_python=1
        python=$name
        ...

We can get the test to pass if one of the py*-sphinx ports is installed and there is a symbolic link from python{,2,3} to an installed python* port. I would prefer to establish a python{,2,3} symbolic link during the build process using something like select, but I was unable to figure out how to make that work. Instead, I resorted to patching the configure script so that ${python} resolves to something that will work.

I admit that the above workaround is quite messy. Is there a cleaner way to handle this? I was having a lot of trouble figuring how to tell the configure script which python I wanted it to use.

[cceleri@…]

I changed for loop in the configure script:

-for name in python python2 python3; do
+for name in ${PREFIX}/bin/python2.7; do

I feel like that should be rock solid as long as py27-sphinx is a dependency of the notmuch port.

An update .diff is now attached.

[cceleri@…]

The part of this patch that removed obsolete patches should have been in the patch for #48666. This should be resolved by the patch I will upload shortly.

[kurthindenburg (Kurt Hindenburg)]

Cc Me!

[petrrr]

Cc Me!

[mojca (Mojca Miklavec)]

If you need sphinx-build, you should probably temporary add /opt/local/Library/Frameworks/Python.framework/Versions/2.7/bin (${frameworks_dir}/Python.framework/Versions/2.7/bin) to PATH. (At least that's what I did in one of my ports.)

[mojca (Mojca Miklavec)]

Also: aren't py27-sphinx and doxygen just build dependencies?

[mojca (Mojca Miklavec)]

Cc Me!

[raimue (Rainer Müller)]

Does not look like this is going anywhere.

[pmetzger (Perry E. Metzger)]

It doesn't look like it is going anywhere because the maintainer probably lost interest when a one year gap appeared between his last diffs and someone replying. We should probably do our best to clean this up and get it in, if only for reasons of project pride.

[rseichter (Ralph Seichter)]

Notmuch 0.28.4 installs man-pages on my machine:

> ls -dl /opt/local/share/man/man1/notmuch*
-r--r--r--  1 root  admin   2,0K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-address.1.gz
-r--r--r--  1 root  admin   1,0K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-compact.1.gz
-r--r--r--  1 root  admin   3,2K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-config.1.gz
-r--r--r--  1 root  admin   1,1K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-count.1.gz
-r--r--r--  1 root  admin   2,1K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-dump.1.gz
-r--r--r--  1 root  admin   1,3K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-emacs-mua.1.gz
-r--r--r--  1 root  admin   2,1K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-insert.1.gz
-r--r--r--  1 root  admin   1,6K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-new.1.gz
-r--r--r--  1 root  admin   1,6K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-reindex.1.gz
-r--r--r--  1 root  admin   2,1K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-reply.1.gz
-r--r--r--  1 root  admin   1,7K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-restore.1.gz
-r--r--r--  1 root  admin   2,6K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-search.1.gz
lrwxr-xr-x  1 root  admin    12B  6 Mai 18:49 /opt/local/share/man/man1/notmuch-setup.1.gz@ -> notmuch.1.gz
-r--r--r--  1 root  admin   3,6K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-show.1.gz
-r--r--r--  1 root  admin   2,0K  6 Mai 18:49 /opt/local/share/man/man1/notmuch-tag.1.gz
-r--r--r--  1 root  admin   3,0K  6 Mai 18:49 /opt/local/share/man/man1/notmuch.1.gz

This ticket has been assigned to me a few hours ago, and I'd like to have it closed if it is no longer relevant. ;-)

[mf2k (Frank Schima)]

Thank you for confirming. It must have gotten fixed at some point.