Opened 9 years ago
Closed 6 years ago
#48668 closed enhancement (fixed)
notmuch: Added +python variant
| Reported by: | cceleri@… | Owned by: | rseichter (Ralph Seichter) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | kurthindenburg (Kurt Hindenburg), petrrr |
| Port: | notmuch |
Description
This patch add the correct support for a +python variant in the Portfile. The corresponding patch for globals.py was also updated appropriately.
Cheers, Charles
Attachments (1)
Change History (13)
comment:1 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 9 years ago by cceleri@…
Ok. I was not aware of the -W option. Looks like it's right in front of me on the portfile(7) manpage though!
Ideally the python27 dependency should be part of the python27 variant; I'm hesitant to role the variant into the normal installation since the bindings are not generally required to run notmuch on a daily basis. There are also bindings for ruby and go which I would like to support in the form of variants in the future too.
I think an explicit python* dependency would be good for each python* variant since we will only need a particular python version to resolve the issue in #48667.
Changed 9 years ago by cceleri@…
| Attachment: | add-python-variant.diff added |
|---|
comment:4 Changed 9 years ago by petrrr
| Keywords: | maintainer added |
|---|
comment:6 Changed 7 years ago by mf2k (Frank Schima)
| Owner: | changed from macports-tickets@… to cceleri@… |
|---|---|
| Status: | new → assigned |
| Version: | 2.3.3 |
comment:7 Changed 7 years ago by mf2k (Frank Schima)
| Owner: | cceleri@… deleted |
|---|
comment:8 Changed 7 years ago by raimue (Rainer Müller)
| Keywords: | lack-of-interest added |
|---|
This ticket is not making progress.
comment:9 follow-up: 11 Changed 6 years ago by mf2k (Frank Schima)
| Owner: | set to rseichter |
|---|
comment:10 Changed 6 years ago by rseichter (Ralph Seichter)
#48667 is resolved. Is this ticket still relevant, or can it be closed as well?
comment:11 Changed 6 years ago by rseichter (Ralph Seichter)
Replying to mf2k: Can you please close this ticket? I don't want to deal with inherited tickets if it is not 100% clear they are still relevant.
comment:12 Changed 6 years ago by mf2k (Frank Schima)
| Keywords: | lack-of-interest removed |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
You should not use
system "cd ${worksrcpath}/bindings/python && ...". Instead, please usesystem -W ${worksrcpath}/bindings/python "...".It looks like this uses python 2.7. As such the variant should probably be named python27 instead of just python.
Since this doesn't add any additional dependencies (python27 is already a dependency through your patch in #48667), does this need to be a variant at all? Couldn't it just be always done?