Opened 9 years ago

Closed 6 years ago

#48809 closed defect (fixed)

Readline incompatibility with lsh

Reported by: greeneg (Gary Greene) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: lsh

Description

While attempting to build lsh, I've found a few errors that block it from building.

First, clang is not compatible with the build unless the -std=gnu89 flag is passed to the compiler since it uses inline externs in a way that is incompatible with C99. After patching the Portfile to use the extra flag for clang, I get errors pointing to readline 6.3 being incompatible with it due to using a function that is no longer present in readline.

At this point, I checked upstream, found that there is a newer release available from the FSF's site, but it also has the same incompatibility with readline 6.3.

Build log for the current version of the port in the repository is attached.

Attachments (3)

main.log​ (76.0 KB) - added by greeneg (Gary Greene) 9 years ago.
Build log for lsh
Portfile​ (1.9 KB) - added by greeneg (Gary Greene) 9 years ago.
Portfile patched with the extra flags for clang
lsh-Portfile.diff​ (1.7 KB) - added by greeneg (Gary Greene) 9 years ago.
Portfile diff

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by greeneg (Gary Greene)

Attachment: main.log​ added

Build log for lsh

Changed 9 years ago by greeneg (Gary Greene)

Attachment: Portfile​ added

Portfile patched with the extra flags for clang

comment:1 Changed 9 years ago by greeneg (Gary Greene)

Added patched version of the port file to add the extra flags for testing by others. Will upload another version of it for the new release for testing tomorrow.

comment:2 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added

You should attach a unified diff of your changes instead of a complete new Portfile.

comment:3 Changed 9 years ago by greeneg (Gary Greene)

As requested, attaching it as a diff.

Changed 9 years ago by greeneg (Gary Greene)

Attachment: lsh-Portfile.diff​ added

Portfile diff

comment:4 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Your diff appears to include unrelated whitespace changes. Please restrict your diff to only the changes that resolve the issue you are reporting.

comment:5 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:6 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

adding this doesn't fix the build for me

configure.cflags-append "-std=gnu89"

comment:7 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign
Status: new → accepted

comment:8 Changed 6 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: → fixed
Status: accepted → closed

In cb339d5d4478a293f96927848f199a31860257f7/macports-ports (master):

lsh: Update to 2.1 and fix build failures

Closes: #40096
Closes: #48809

Note: See TracTickets for help on using tickets.