Opened 8 years ago

Closed 6 years ago

#51395 closed defect (fixed)

screen @4.3.1_1 runtime Abort Trap on 10.5 in tty.sh/CheckTTYName/realpath

Reported by: smbmacportstrac@… Owned by: dgilman (David Gilman)
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: haspatch Cc:
Port: screen

Description

A patch for Solaris regarding the use of realpath() fixes a similar problem on MacOS X Leopard (10.5/Darwin9). ​https://savannah.gnu.org/bugs/?45751 I downloaded the patch and modified it to work with MacPorts. (Patch attached.) The Portfile just needs to reference the patch. (Patch attached.)

Attachments (1)

screen-4.3.1-10.5-AbortTrap-fix.tar.gz​ (942 bytes) - added by smbmacportstrac@… 8 years ago.
Proposed patch

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by smbmacportstrac@…

Attachment: screen-4.3.1-10.5-AbortTrap-fix.tar.gz​ added

Proposed patch

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Cc: youvegotmoxie@… removed
Owner: changed from macports-tickets@… to youvegotmoxie@…

comment:2 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

Owner: youvegotmoxie@… deleted
Status: new → assigned

comment:3 Changed 6 years ago by dgilman (David Gilman)

Owner: set to dgilman
Resolution: → fixed
Status: assigned → closed

In 7c8e45245901fcd37fdf2263f2d2b61f034d2444/macports-ports (master):

screen: update to 4.6.2

Big reorganization of how this portfile gets patched. I went back to
Apple's screen-22 source, extracted their patches, rebased them against
latest, and put them together in a single file patch-apple.diff which
contains all of them. I think this will be more manageable going
forward.

I figured out the purpose of patch-config.h.in.diff and left a note in
that file explaining what it does.

I removed support for the MacOS X 10.5 patches. I have no machine to
test this and those are pretty old systems anyway.

Patches I removed:

  • patch-Makefile.in.diff: Upstream builds just fine without this, so

removing them. It stripped CFLAGS from a build line, no idea what the
offending CFLAGS might have been.

  • patch-configure-libelf.diff: This is a fix to a ./configure check for

the existence of SVR4. We are not SVR4, who cares if it is broken.
patch-configure.diff: More fixes to ./configure to detect utmp support.
Apple's patch uses /usr/bin/login to handle utmp so no need for
this.

  • patch-marxargs.diff: Not used in old portfile.
  • patch-process.c-fix-bogus-strncpy-size.diff: Fixed upstream.
  • patch-pty.c.diff: Not used in old portfile.
  • patch-screen.c-leopard.diff: Removed 10.5 support.
  • patch-utmp.c: This appears to be a half-hearted attempt at fixing up

utmp support under MacOS X. Unfortunately for the patch author MacOS X
does not have a utmp, it uses utmpx, and we disable support for utmp
editing at compile time. This patch is pointless and was removed.

  • patch-windowsize.diff: This patch has been updated but in a slightly

different form.

Patches that are now part of patch-apple.diff:

  • patch-screen.c.diff
  • patch-window.c.diff

Closes: #44279
Closes: #53355
Closes: #51395

Note: See TracTickets for help on using tickets.