screen @4.3.1_1: update to 4.6.1

[ojkastl]

The screen port is at version 4.3.1, version 4.5.0 was released on January 18th.

I just fumbled around with the Portfile, left out the patches and adjusted the checksums. And voilá, screen builds. As I have no clue what the patches are actually doing, I do not know if they are necessary anymore. But screen seems to run without them.

So, can the port please be updated?

[ryandesign (Ryan Carsten Schmidt)]

Perhaps you would attach a diff of the changes you made that worked for you?

There are many patchfiles in the current version. It would perhaps be necessary to understand why each of them is there before knowing whether it is safe to remove them.

[ojkastl]

I'll attach the diff from 'diff -u Portfile.orig Portfile'.

As I wrote on the mailinglist, I have no idea what the patches do exactly, so maybe someone who does should consider dropping them or not.

[ojkastl]

Unified diff of original portfile vs. my test Portfile

[mf2k (Frank Schima)]

Notes on your patch:

• The revision line should be deleted because it starts at 0 when increasing the version and that is the default value.
• Please restore and update the rmd160 checksum. We like to have at least 2.

[ojkastl]

Thanks for the tips.

But only somebody, who knows what the patches are/were supposed to do and if they should be deleted, should update this port (aka not me). And I hope, he already knows that...

[1-61803]

As of now it's at 4.5.1.

[slybart77]

A new version has been released. screen 4.6.2.

[dgilman (David Gilman)]

In 7c8e45245901fcd37fdf2263f2d2b61f034d2444/macports-ports (master):

screen: update to 4.6.2

Big reorganization of how this portfile gets patched. I went back to
Apple's screen-22 source, extracted their patches, rebased them against
latest, and put them together in a single file patch-apple.diff which
contains all of them. I think this will be more manageable going
forward.

I figured out the purpose of patch-config.h.in.diff and left a note in
that file explaining what it does.

I removed support for the MacOS X 10.5 patches. I have no machine to
test this and those are pretty old systems anyway.

Patches I removed:

• patch-Makefile.in.diff: Upstream builds just fine without this, so

removing them. It stripped CFLAGS from a build line, no idea what the
offending CFLAGS might have been.

• patch-configure-libelf.diff: This is a fix to a ./configure check for

the existence of SVR4. We are not SVR4, who cares if it is broken.
patch-configure.diff: More fixes to ./configure to detect utmp support.
Apple's patch uses /usr/bin/login to handle utmp so no need for
this.

• patch-marxargs.diff: Not used in old portfile.
• patch-process.c-fix-bogus-strncpy-size.diff: Fixed upstream.
• patch-pty.c.diff: Not used in old portfile.
• patch-screen.c-leopard.diff: Removed 10.5 support.
• patch-utmp.c: This appears to be a half-hearted attempt at fixing up

utmp support under MacOS X. Unfortunately for the patch author MacOS X
does not have a utmp, it uses utmpx, and we disable support for utmp
editing at compile time. This patch is pointless and was removed.

• patch-windowsize.diff: This patch has been updated but in a slightly

different form.

Patches that are now part of patch-apple.diff:

• patch-screen.c.diff
• patch-window.c.diff

Closes: #44279
Closes: #53355
Closes: #51395