ldas-tools being obsoleted

[emaros]

The ldas-tools package has been obsoleted and now a collection of 7 packages.

[mf2k (Frank Schima)]

Thanks. ​Per the guidelines, normally you should attach a Portfile patch.

[ryandesign (Ryan Carsten Schmidt)]

Did you see my previous ticket #51609 where I requested this update? There are various suggestions in that ticket that might be helpful. For example, is it really appropriate to mark ldas-tools replaced_by ldas-tools-al? Did ldas-tools 2.4.2 only contain the files now contained in ldas-tools-al 2.5.0, or did ldas-tools 2.4.2 also contain files now contained in the other ports? If the latter, it would be more appropriate to make ldas-tools a meta port that depends on all the other ports.

[emaros]

Replying to ryandesign@…:

Did you see my previous ticket #51609 where I requested this update? There are various suggestions in that ticket that might be helpful. For example, is it really appropriate to mark ldas-tools replaced_by ldas-tools-al? Did ldas-tools 2.4.2 only contain the files now contained in ldas-tools-al 2.5.0, or did ldas-tools 2.4.2 also contain files now contained in the other ports? If the latter, it would be more appropriate to make ldas-tools a meta port that depends on all the other ports.

The original ldas-tools package originally contained all of the content of each ldas-tools-* package. I would be willing to make it a meta package, but still want the ability to install a strict subset of the ldas-tools packages also. Is that possible?

[ryandesign (Ryan Carsten Schmidt)]

Certainly. It would just mean that users who already had ldas-tools 2.4.2 installed will be upgraded to the full set of separate ports.

Did you consider using subports? It looks like there's a bit of common code between the separate portfiles you submitted; a single common set of code could be shared by using subports.

[emaros]

Replying to ryandesign@…:

Certainly. It would just mean that users who already had ldas-tools 2.4.2 installed will be upgraded to the full set of separate ports.

Did you consider using subports? It looks like there's a bit of common code between the separate portfiles you submitted; a single common set of code could be shared by using subports.

Are there examples of Portfiles that are metapackages and projects that use subports? I would like to take the project in these directions.

[emaros]

Diff to the 2.4.2 version of the Portfile

[emaros]

I have modified the Portfile to be a meta package for the ldas-tools suite of tools. This replaces the previous Portfile which flagged the project as obsolete.

[emaros]

Replying to ed.maros@…:

I have modified the Portfile to be a meta package for the ldas-tools suite of tools. This replaces the previous Portfile which flagged the project as obsolete.

Is there work still to be done on this Portfile before it can be accepted?

[skymoo (Adam Mercer)]

Tried updating to the new ports and it failed with the following:

[ram@hastur ~]$ port outdated
The following installed ports are outdated:
ldas-tools                     2.4.2_1 < 20160622_0
[ram@hastur ~]$ sudo port upgrade outdated
--->  Computing dependencies for ldas-tools-al
Error: Unable to exec port: Can't install ldas-tools-al because
conflicting ports are active: port:ldas-tools
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
[ram@hastur ~]$

I added the following code to ldas-tools-al to deactivate ldas-tools during the pre-activate stage (and remove the conflict) and then it all seems to work:

pre-activate {
  # ldas-tools-al now contains files that used to be provided by ldas-tools
  if {![catch {set installed [lindex [registry_active ldas-tools] 0]}]} {
    set _version [lindex $installed 1]
    if {[vercmp $_version 2.5.0] < 0} {
      # ldas-tools used to install some files now provided by ldas-tools in versions < 2.5.0
      registry_deactivate_composite ldas-tools "" [list ports_nodepcheck 1]
    }
  }
}

If there are no objections to these changes I'll incorporate this into the patch set and push the changes in the morning.

[skymoo (Adam Mercer)]

Cc Me!

[skymoo (Adam Mercer)]

r151462