ldas-tools-al

[emaros]

This is the first package broken out of ldas-tools

[mf2k (Frank Schima)]

See #51625.

[ryandesign (Ryan Carsten Schmidt)]

This port should not be marked as conflicting with ldas-tools. Your current ldas-tools submission is marked replaced_by ldas-tools-as. As such, the conflicts marking will prevent the replacement from working. My suggestion was to make ldas-tools a meta port; in that case, you would not want a conflicts marking either; instead, you would want to use the deactivate hack.

You shouldn't base the decision about whether to use C++11 on whether the OS X version is Mavericks or greater. Instead, you should base it on whether configure.cxx_stdlib equals libc++.

The openssl dependency should be written in such a way that libressl could satisfy it. See other ports that depend on openssl for the correct syntax.

[ryandesign (Ryan Carsten Schmidt)]

configure.args-strsed is ancient. You should probably use configure.args-replace instead. (configure.args-replace --disable-python --enable-python)

It doesn't look like the livecheck has been updated for the changed distfile names.

[emaros]

Replying to ryandesign@…:

configure.args-strsed is ancient. You should probably use configure.args-replace instead. (configure.args-replace --disable-python --enable-python)

It doesn't look like the livecheck has been updated for the changed distfile names.

I have opened a ticket for this on the main ticketing system for the software package and will make the modification for the next release of the software.

[skymoo (Adam Mercer)]

r151455

[ryandesign (Ryan Carsten Schmidt)]

Replying to ryandesign@…:

You shouldn't base the decision about whether to use C++11 on whether the OS X version is Mavericks or greater. Instead, you should base it on whether configure.cxx_stdlib equals libc++.

The openssl dependency should be written in such a way that libressl could satisfy it. See other ports that depend on openssl for the correct syntax.

Replying to ryandesign@…:

configure.args-strsed is ancient. You should probably use configure.args-replace instead. (configure.args-replace --disable-python --enable-python)

It doesn't look like the livecheck has been updated for the changed distfile names.

These issues should have been resolved before committing.

[skymoo (Adam Mercer)]

Apologies I was under the impression that these issues had been addressed, I didn't check too closely.

Ed: Can you get a patch together to address these issues?

[emaros]

Replying to ram@…:

Apologies I was under the impression that these issues had been addressed, I didn't check too closely.

Ed: Can you get a patch together to address these issues?

The patch file addresses all of the issues mentioned above.

[skymoo (Adam Mercer)]

Thanks Ed,

Ryan: Are you happy with these changes?

[skymoo (Adam Mercer)]

Ryan: Do the attached changes address your concerns?

[skymoo (Adam Mercer)]

I'm with with Ed off list on an update to this port that address these issues along with updating to the next version. I'm going to close this ticket out as to avoid confusion when we're ready to submit the update.