Opened 8 years ago

Closed 7 years ago

#53300 closed defect (fixed)

QGIS @ 2_18_2_2: Port's version number has underscores where it should have dots

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: Veence (Vincent)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: QGIS

Description

The QGIS port advertises that it installs version "2_18_2" of the software:

$ port list QGIS
QGIS                           @2_18_2         gis/qgis

But as far as I know, it actually installs version "2.18.2" of the software. The next time you update the port to a new version, please make sure the port advertises the software's correct version number.

It looks like you're setting version to the correct value, but then calling github.setup afterwards, which resets the version to whatever value was provided in the github.setup line. The expected usage is that you call github.setup first, then override the version later if needed.

Change History (3)

comment:1 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

You've added a qgis3 port where you handle this correctly, so now you just need to fix it in QGIS too.

comment:2 Changed 7 years ago by Veence (Vincent)

In 13b092151d67effa43d70f7792a174e9f566c64e/macports-ports:

qgis: deprecate qt5 variant (→ qgis3) and various improvements and tidying-up.
Should fix: #52339
and: #53300

comment:3 Changed 7 years ago by Veence (Vincent)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.