Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#55334 closed enhancement (fixed)

atom @1.22.0: install shell commands

Reported by: l2dy (Zero King) Owned by: kurthindenburg (Kurt Hindenburg)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: atom

Description

These symbolic links are created in /usr/local/bin if I select "Install Shell Commands" from Atom menu (installed from upstream binary).

apm -> /Applications/Atom.app/Contents/Resources/app/apm/node_modules/.bin/apm
atom -> /Applications/Atom.app/Contents/Resources/app/atom.sh

Should these links be created in ${prefix}/bin?

Change History (3)

comment:1 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

I've patched it so the links are under {prefix}bin/ - however, they are not owned by the atom port; so upon uninstall they link will still be there. I'm not sure what the best way to handle this is.

comment:2 Changed 7 years ago by l2dy (Zero King)

I was asking if we should install these links (ln -s ${applications_dir}/Atom.app/... ${destroot}${prefix}/bin/...) in the Portfile.

I don't think letting users install links not managed by MacPorts within ${prefix} is a good idea.

Last edited 7 years ago by l2dy (Zero King) (previous) (diff)

comment:3 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

In c524dd7b7cd2af619ff94fd56a4a1fccbe01aa09/macports-ports:

atom: update to 1.22.1

Adjust command installer paths to ${prefix}; add two links (atom/apm)
that the command installer would install.

closes #55334

Note: See TracTickets for help on using tickets.